Repository navigation
ci: use the npm lockfile for Bun and Deno tests - #380
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bun and Deno jobs each installed their own dependency tree, so a dependency update could leave the three runtimes testing different versions. Both jobs now use
npm ci, and we only need to maintainpackage-lock.json.Bun runs the installed Vitest CLI with
--bunso its Node shebang can't switch the runner back to Node. Deno runs the same CLI with manualnode_modulesresolution and--no-lock.Verified from a clean npm install with Bun 1.4.4 and Deno 2.9.6. Both runs passed 75 tests with one skipped.