Skip to content

test(weather): make widget refresh startup test deterministic #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YinCheng0106 merged 1 commit into from
Oct 11, 2026
Merged

test(weather): make widget refresh startup test deterministic #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions ios/RunnerTests/SavedCurrentWeatherWidgetRefreshServiceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ final class SavedCurrentWeatherWidgetRefreshServiceTests: XCTestCase {
func testWeatherAndClockStartBeforeEitherCompletes() async throws {
let weatherGate = AsyncOperationGate()
let clockGate = AsyncOperationGate()
let weatherStarted = expectation(description: "Weather fetch started")
let clockStarted = expectation(description: "Clock synchronization started")
let observation = try makeObservation()
let writer = CurrentWeatherSnapshotWriterSpy()
let resolver = try makeResolver(codes: ["242"])
Expand All @@ -343,10 +345,12 @@ final class SavedCurrentWeatherWidgetRefreshServiceTests: XCTestCase {
},
pipeline: CurrentWeatherWidgetRefreshPipeline(
fetchWeather: { _, _ in
weatherStarted.fulfill()
await weatherGate.wait()
return observation
},
synchronizeClock: {
clockStarted.fulfill()
await clockGate.wait()
return self.makeSnapshotTime()
},
Expand All @@ -362,18 +366,11 @@ final class SavedCurrentWeatherWidgetRefreshServiceTests: XCTestCase {
target: .saved(regionCode: "242")
)
}
for _ in 0..<200 {
if await weatherGate.hasStarted,
await clockGate.hasStarted {
break
}
await Task.yield()
}
await fulfillment(of: [weatherStarted, clockStarted], timeout: 5)

let weatherStarted = await weatherGate.hasStarted
let clockStarted = await clockGate.hasStarted
XCTAssertTrue(weatherStarted)
XCTAssertTrue(clockStarted)
// Keep both operations blocked until startup is verified, and release
// both gates even after a timeout so the refresh task can finish.
XCTAssertEqual(writer.writeCount, 0)
await weatherGate.open()
await clockGate.open()
let result = await refresh.value
Expand Down