Skip to content

[HOLD on #102135] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 - #102422

Open
chrispader wants to merge 20 commits into
Expensify:mainfrom
margelo:@chrispader/chore/update-nitro-sqlite-10.0.0
Open

chrispader wants to merge 20 commits into
Expensify:mainfrom
margelo:@chrispader/chore/update-nitro-sqlite-10.0.0

Conversation

@chrispader

@chrispader chrispader commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The new Onyx SQLite provider requires NitroSQLite 10.2.0. I updated Onyx to the published 3.0.121 release and NitroSQLite to 10.2.0.

Explanation of Change

This integrates the provider changes from Onyx #851. I removed the legacy debug getter because it overwrites Onyx's public get API. Extensive benchmarks were already completed and reported in that Onyx PR.

Fixed Issues

$ #102424

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14179

Depends on #102135.

Tests

Use an iOS or Android build containing this PR and the linked Mobile-Expensify PR. Sign in before starting.

  1. Send a message in an existing chat, then edit it. Force-close and reopen the app. Verify the edited message appears once and the previous chat history is still visible.
  2. Go offline and create a manual expense with a merchant and amount. Force-close and reopen the app while still offline, and verify the expense details persist. Reconnect and verify the expense syncs with the same details and no duplicate is created.

Verify there are no JS console errors during either flow.

Offline tests

Covered by flow 2 in Tests.

QA Steps

Run the full QA suite on all supported platforms, especially the two flows in Tests. Use a HybridApp staging build containing both linked PRs for native testing.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above

  • I wrote clear testing steps that cover the changes made in this PR

    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms

  • I ran the tests on all platforms & verified they passed on:

    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

  • I followed proper code patterns (see Reviewing the code)

    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

  • I followed the guidelines as stated in the Review Guidelines

  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

  • If a new CSS style is added I verified that:

    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:

    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.

  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

  • Verify that no errors appear in the JS console

  • Verify that no errors appear in the JS console

  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)

  • If the PR adds or modifies the UI:

    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).

Screenshots/Videos

Attach a screenshot of the edited message after relaunch and a screenshot of the synced expense after reconnecting.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@chrispader chrispader changed the title [HOLD on #851] chore(deps): Update NitroSQLite to 10.0.0 [HOLD on Onyx #851] chore(deps): Update NitroSQLite to 10.0.0 Sep 28, 2026
@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/setup/addUtilsToWindow.ts 16.43% <ø> (-0.02%) ⬇️
... and 114 files with indirect coverage changes

@chrispader chrispader changed the title [HOLD on Onyx #851] chore(deps): Update NitroSQLite to 10.0.0 [HOLD on https://github.com/Expensify/react-native-onyx/pull/851] chore(deps): Update NitroSQLite to 10.0.0 Sep 28, 2026
@chrispader

Copy link
Copy Markdown
Contributor Author

@MelvinBot create a new issue for upgrading NitroSQLite from 9.8.2 (after #101448 has been merged) to latest 10.0.0. NitroSQLite added new features such as prepared statements, independent DB connections and multiple performance improvements.

This requires also updating the peer dependency range in Onyx.

@MelvinBot assign me to the issue and add it to the PR description here and in Expensify/react-native-onyx#851!

@MelvinBot

Copy link
Copy Markdown
Contributor

I created chore(deps): Upgrade NitroSQLite from 9.8.2 to 10.0.0 and assigned you. It is held on chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0. It covers prepared statements, independent connections, the performance improvements, and the Onyx peer dependency range update.

I found no existing issue for this upgrade.

@chrispader
chrispader force-pushed the @chrispader/chore/update-nitro-sqlite-10.0.0 branch from c27cbbd to 3d6d5d2 Compare October 1, 2026 08:30
@chrispader chrispader changed the title [HOLD on https://github.com/Expensify/react-native-onyx/pull/851] chore(deps): Update NitroSQLite to 10.0.0 [HOLD on https://github.com/Expensify/react-native-onyx/pull/851] chore(deps): Update NitroSQLite to 10.2.0 Oct 12, 2026
@chrispader
chrispader marked this pull request as ready for review October 12, 2026 16:52
@chrispader
chrispader requested review from a team as code owners October 12, 2026 16:52
@melvin-bot
melvin-bot Bot requested review from dmkt9 and trjExpensify and removed request for a team October 12, 2026 16:52
@melvin-bot

melvin-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-12T17:24:11.193455Z 682344e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@trjExpensify
trjExpensify removed their request for review October 12, 2026 20:16
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as an version upgrade PR. Unassigning and unsubscribing myself.

@NicolasBonet NicolasBonet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many conflicts

@chrispader chrispader changed the title [HOLD on https://github.com/Expensify/react-native-onyx/pull/851] chore(deps): Update NitroSQLite to 10.2.0 [WIP] [HOLD on #102135] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 Oct 21, 2026
@chrispader chrispader changed the title [WIP] [HOLD on #102135] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 [HOLD on #102135] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 Oct 21, 2026
@fabioh8010

Copy link
Copy Markdown
Contributor

@chrispader if you are bumping straight to 3.0.121 you need to test and add steps for 3.0.120

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants