Repository navigation
[HOLD on #102135] chore(deps): update Onyx to 3.0.121 and NitroSQLite to 10.2.0 - #102422
chrispader wants to merge 20 commits into
Conversation
|
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot create a new issue for upgrading NitroSQLite from 9.8.2 (after #101448 has been merged) to latest 10.0.0. NitroSQLite added new features such as prepared statements, independent DB connections and multiple performance improvements. This requires also updating the peer dependency range in Onyx. @MelvinBot assign me to the issue and add it to the PR description here and in Expensify/react-native-onyx#851! |
|
I created chore(deps): Upgrade NitroSQLite from 9.8.2 to 10.0.0 and assigned you. It is held on chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0. It covers prepared statements, independent connections, the performance improvements, and the Onyx peer dependency range update.
I found no existing issue for this upgrade. |
c27cbbd to
3d6d5d2
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pin Onyx 6ee48a7f and reuse the derived reference-stability fixes and tests from Expensify#98956.
|
PR doesn’t need product input as an version upgrade PR. Unassigning and unsubscribing myself. |
|
@chrispader if you are bumping straight to 3.0.121 you need to test and add steps for 3.0.120 |
The new Onyx SQLite provider requires NitroSQLite 10.2.0. I updated Onyx to the published 3.0.121 release and NitroSQLite to 10.2.0.
Explanation of Change
This integrates the provider changes from Onyx #851. I removed the legacy debug getter because it overwrites Onyx's public
getAPI. Extensive benchmarks were already completed and reported in that Onyx PR.Fixed Issues
$ #102424
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14179
Depends on #102135.
Tests
Use an iOS or Android build containing this PR and the linked Mobile-Expensify PR. Sign in before starting.
Verify there are no JS console errors during either flow.
Offline tests
Covered by flow 2 in Tests.
QA Steps
Run the full QA suite on all supported platforms, especially the two flows in Tests. Use a HybridApp staging build containing both linked PRs for native testing.
PR Author Checklist
I linked the correct issue in the
### Fixed Issuessection aboveI wrote clear testing steps that cover the changes made in this PR
TestssectionOffline stepssectionQA stepssectionI included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarare working as expected)If a new CSS style is added I verified that:
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))If new assets were added or existing ones were modified, I verified that:
npm run compress-svg)If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases)If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
Designlabel and/or tagged@Expensify/designso the design team can review the changes.I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Verify that no errors appear in the JS console
Verify that no errors appear in the JS console
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If the PR adds or modifies the UI:
Screenshots/Videos
Attach a screenshot of the edited message after relaunch and a screenshot of the synced expense after reconnecting.