[elirangoshen]

Explanation of Change

[TESTING ONLY, do not merge]

Some users get stuck on infinite skeletons after switching accounts in a browser that is already signed in to NewDot (Supportal, OldDot transition, or re-auth). The logging added in #104456 confirmed the cause in production: the sign-out Onyx.clear finishes after the new sign-in has started, and when it finishes it resets session and the request queue. In 32 of 34 logged cases the new login token was wiped, so every request after that got a 407; in others the queued OpenApp was dropped.

The fix is in Onyx: Onyx.clear no longer overwrites keys that were written while it was running. Companion Onyx PR: Expensify/react-native-onyx#881

This PR only changes the Onyx version. No App code changes.

Onyx version: react-native-onyx is pinned to callstack-internal/react-native-onyx#b5f84a4a, which is the #881 fix applied on top of 3.0.117, the version App ships today. This way CI tests only the fix. The fix itself targets Onyx main; pinning App to it would also pull in 3.0.118 to 3.0.123, which need the async Onyx.get migration (#102135) and react-native-nitro-sqlite 10. App gets the fix through the regular Onyx bump once #881 is released.

Fixed Issues

$ #104458
PROPOSAL: N/A

Automated Tests

Covered in the Onyx PR by tests/unit/onyxClearConcurrentWriteTest.ts, which writes keys while a clear is running and checks they keep their new value in subscribers, the cache and storage.

Tests

1. On web, sign in to NewDot as account A.
2. In the same browser, open a Supportal or OldDot transition link for a different account B.
3. Verify account B loads normally (no infinite skeletons).
4. Verify the console does not show [SignInRedirect] Sign-out clear finished after a new sign-in started with isNewSessionWiped: true.
5. Sign out, then sign in as account A again. Verify none of account B's data (chats, workspaces) is shown.

• Verify that no errors appear in the JS console

Offline tests

1. Sign in as account A and go offline.
2. Sign out, go back online and sign in as account B.
3. Verify account B loads normally and none of account A's data is shown.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️