[Payment due @parasharrajat] [No QA] Bump react-native-onyx to 3.0.109 by NicolasBonet · Pull Request #99436 · Expensify/App

NicolasBonet · 2026-08-25T14:29:36Z

Explanation of Change

Bumps react-native-onyx to 3.0.109, which includes Expensify/react-native-onyx#830 (this PR served as its linked E/App validation PR while the change was pinned to the PR's HEAD via git+https, and the full E/App CI suite passed against it).

The Onyx change is toolchain-only (Node/npm floor via devEngines, .nvmrc bump, engine-strict): no runtime code changes, and devEngines is never evaluated when Onyx is installed as a dependency, so there is no consumer-facing behavior change.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/675045
PROPOSAL: N/A (internal toolchain change, no proposal flow)

Tests

Run npm install and verify it completes with react-native-onyx@3.0.109.
Run the app and verify it boots and Onyx-backed screens (e.g. chat list) load normally.
Verify that no errors appear in the JS console

Offline tests

N/A — dependency pin only, no runtime code changes in Onyx (toolchain/config only).

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

Validation PR for Expensify/react-native-onyx#830 — runs the full E/App suite against the Onyx PR head. Will be swapped to the published version once the Onyx PR merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

melvin-bot · 2026-08-26T19:05:30Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # package-lock.json # package.json

roryabraham

Looks like these changes are mostly simple and look low-risk, but I'll await C+ review nonetheless.

roryabraham · 2026-08-31T19:56:31Z

@NicolasBonet see this comment for the Onyx bump queue. I suggest that we wait for #97857 to land independently before continuing with this.

NicolasBonet · 2026-08-31T20:56:40Z

@parasharrajat any chance to have this check today?

parasharrajat · 2026-09-01T03:27:05Z

Sure. Will be done today.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

01.09.2026_15.54.00_REC.mp4

🎀 👀 🎀 C+ reviewed

melvin-bot · 2026-09-01T10:29:58Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-09-01T10:29:59Z

🎯 @parasharrajat, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/675045.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

github-actions · 2026-09-01T18:02:21Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-01T18:06:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-01T18:07:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99436.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1d0a1db-b66008c-d074b73588aaa129038dd9f45cdf331beb9176b7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1d0a1db-b66008c-4b8f0b291eb720eaf7231b96ba8593f6c2737d1a/index.html

Web 🕸️
https://99436.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-02T00:36:15Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-09-02T21:11:43Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.68-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-09-02T21:48:59Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot · 2026-09-02T21:53:18Z

🤖 Payment issue created: #100226

melvin-bot Bot assigned NicolasBonet Aug 25, 2026

NicolasBonet mentioned this pull request Aug 25, 2026

Enforce npm 11.10.0 minimum via devEngines and engine-strict Expensify/react-native-onyx#830

Merged

42 tasks done

Bump react-native-onyx to 3.0.109

7976998

NicolasBonet changed the title ~~[No QA] Pin react-native-onyx to react-native-onyx#830 HEAD for validation~~ [No QA] Bump react-native-onyx to 3.0.109 Aug 26, 2026

NicolasBonet marked this pull request as ready for review August 26, 2026 19:05

NicolasBonet requested a review from a team as a code owner August 26, 2026 19:05

melvin-bot Bot requested review from parasharrajat and removed request for a team August 26, 2026 19:05

Merge remote-tracking branch 'upstream/main' into nicolas-onyx-830-pin

9592ca0

# Conflicts: # package-lock.json # package.json

roryabraham previously approved these changes Aug 31, 2026

View reviewed changes

NicolasBonet changed the title ~~[No QA] Bump react-native-onyx to 3.0.109~~ [Hold App#97857] [No QA] Bump react-native-onyx to 3.0.109 Aug 31, 2026

elirangoshen mentioned this pull request Sep 1, 2026

[Onyx bump] Bump react-native-onyx from 3.0.101 to 3.0.102 #97857

Merged

40 tasks done

parasharrajat approved these changes Sep 1, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia September 1, 2026 10:29

melvin-bot Bot changed the title ~~[Hold App#97857] [No QA] Bump react-native-onyx to 3.0.109~~ [Payment due @parasharrajat] [Hold App#97857] [No QA] Bump react-native-onyx to 3.0.109 Sep 1, 2026

grgia previously approved these changes Sep 1, 2026

View reviewed changes

Merge main into nicolas-onyx-830-pin, keep react-native-onyx 3.0.109

cfd2d3c

NicolasBonet dismissed stale reviews from grgia and roryabraham via cfd2d3c September 1, 2026 17:25

NicolasBonet requested a review from a team as a code owner September 1, 2026 17:25

melvin-bot Bot requested review from heyjennahay and removed request for a team September 1, 2026 17:25

Restore oxfmt formatting in TransactionUtils/index.ts

9ace07a

NicolasBonet changed the title ~~[Payment due @parasharrajat] [Hold App#97857] [No QA] Bump react-native-onyx to 3.0.109~~ [Payment due @parasharrajat] [No QA] Bump react-native-onyx to 3.0.109 Sep 1, 2026

roryabraham approved these changes Sep 1, 2026

View reviewed changes

roryabraham merged commit 1d0a1db into main Sep 1, 2026
48 of 49 checks passed

roryabraham deleted the nicolas-onyx-830-pin branch September 1, 2026 18:01

OSBotify mentioned this pull request Sep 2, 2026

Deploy Checklist: New Expensify 2026-09-02 #100087

Closed

82 tasks done

melvin-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-09] Payment issue for E/App PR#99436 #100226

Closed

fabioh8010 mentioned this pull request Sep 3, 2026

[Due for payment 2026-09-28] [Onyx] Investigate UnknownError: Attempt to generate key in database without an in-progress transaction storage error #100046

Closed

Conversation

NicolasBonet commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot Bot commented Aug 26, 2026

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Aug 31, 2026

Uh oh!

NicolasBonet commented Aug 31, 2026

Uh oh!

parasharrajat commented Sep 1, 2026

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

melvin-bot Bot commented Sep 1, 2026

Uh oh!

melvin-bot Bot commented Sep 1, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

OSBotify commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

melvin-bot Bot commented Sep 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NicolasBonet commented Aug 25, 2026 •

edited

Loading