Repository navigation
Upgrade TypeScript to 7.0.2 - #807
Closed
roryabraham wants to merge 3 commits into
Closed
roryabraham wants to merge 3 commits into
roryabraham wants to merge 3 commits into
Conversation
Move the repo to TypeScript 7 stable and update tsconfig for TS 7 module resolution and rootDir requirements. Compile GitHub Action sources with tsc before ncc because ncc's ts-loader is incompatible with TypeScript 7, and use legacy-peer-deps in CI until typescript-eslint officially supports TS 7. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the existing pinned ncc version instead of allowing caret upgrades during the TypeScript 7 migration. Co-authored-by: Cursor <cursoragent@cursor.com>
ncc cannot compile TypeScript sources directly with TS 7, so compile action sources with tsc first and bundle the JavaScript output. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Upgrade
typescriptfrom 5.9.x to TypeScript 7.0.2 (latest stable v7).tsconfig.jsonfor TS 7:moduleResolution: "bundler"(replaces removednode10), explicitincludepaths, androotDirintsconfig.build.json.@typescript/native-previewortsgousage was present; the repo continues using standardtsc.package.jsonoverrides so@typescript-eslint/*resolves against TS 7 until official peer dependency support lands.npm ciinvocations to use--legacy-peer-depsfor the same reason.buildActions.shto compile GitHub Action TypeScript withtscbeforencc, becausencc's ts-loader is incompatible with TypeScript 7.Related Issues
N/A
Linked E/App PR
Automated Tests
No new automated tests. Verified locally:
npm run typechecknpm run buildnpm run test:typesnpm run gh-actions-buildManual Tests
N/A — dev tooling upgrade only.
Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari