Repository navigation
Upgrade reassure to 1.6.0 to fix mathjs vulnerabilities - #879
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@MelvinBot can you fix the conflicts again? Also find a PR that updates the react-native-onyx package and link it here as the related PR please |
…eForMathjs # Conflicts: # package-lock.json
|
@madmax330 I think Melvin doesn't respond in public repos other than App, you can get him to update the PR from your Slack DM if you want though (but looks like you're all set here...) 😄 |
Details
Upgrades
reassure1.4.0 → 1.6.0, which bumps transitivemathjs13.2.3 → 15.2.0 to fix two high-severity Dependabot alerts (unsafe object property setter). 1.6.1 is skipped because.npmrcmin-release-age=7blocks it.Usage: dev-only.
reassureruns the perf tests intests/perf-test/(npm run perf-test) and thereassurePerfTests.ymlworkflow.validateReassureOutputreads itsoutput.json. Not part of the published package.Change Log
1.6.0
1.5.1
@callstack/reassure-danger1.5.0
render/cleanupfrom React Native Testing Library v14simple-git, update eslint to v10, upgrade deps (mathjs^15.2.0,pretty-format^30,zod^4)1.4.1 (
reassure-measureonly)mathjs^15.1.0,pretty-format^30.2.0Source: reassure CHANGELOG
Related Issues
https://github.com/Expensify/react-native-onyx/security/dependabot?q=is%3Aopen+package%3Amathjs
Linked E/App PR
Expensify/App#102135
Automated Tests
None added; dependency bump only. Melvin ran these locally on Node 24.22.1:
npm run typecheck,npm run lint: passnpm test: 707/707 passnpx reassure: 101/101 perf tests passreassure-compare+node .github/actions/javascript/validateReassureOutput:output.jsonparsed fineManual Tests
npm ci, thennpm ls mathjs. Confirm onlymathjs@15.2.0.npm run perf-test. Confirm all perf tests pass and.reassure/current.perfis written.Reassure Performance Testsworkflow passes on this PR.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari