Repository navigation
Support BitMap64 ranges that end at the maximum value - #154
Open
Shaisolaris wants to merge 1 commit into
Open
Shaisolaris wants to merge 1 commit into
Shaisolaris wants to merge 1 commit into
Conversation
Range methods passed an exclusive uint64 end, so an end of 2**64 overflowed. Use the closed roaring64 range functions instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 64-bit range methods take an exclusive end as
uint64_t, so a range that includes the largest value (end2**64) raisesOverflowError, while the 32-bitBitMaphandles its own maximum:This affects
add_range,remove_range,flip,flip_inplace,contains_range,range_cardinalityand therangeconstructor path.The change calls the closed
roaring64_*_closedfunctions withend - 1, after checking that the end is between 0 and2**64and handling empty ranges first. Ends above2**64, negative ends and non-integers still raise as before.Tests: added
TestRangeToMaximumintest.py. Locally (Python 3.12, Linux x86_64), with the new tests on the current master the 64-bit run has 4 of them failing; with this change they pass.test.pyandtest_state_machine.pyotherwise give the same results before and after for bothROARING_BITSIZE=32and64.TestFFI::test_ffi_cardinalityfails in my local build both before and after (an undefined symbol via ctypes), so I don't think it's related. I did not run other platforms.