Repository navigation
fix(model): read generated getters from their storage instance - #609
Merged
Merged
Conversation
Draft
FCO
force-pushed
the
split/generated-projection-getters
branch
from
October 28, 2026 00:45
1b2d93a to
676fa83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read generated projection getters from the attribute on the receiving storage instance instead of calling the nonexistent
get_valuemethod on a ResultSeq.Add a regression that captures and invokes the generated methods directly, so automatic accessors cannot mask the bug. Verify separate columns/instances, updated values and zero database queries.
Validation:
RAKUDO_RAKUAST=0 prove6 -lj4 tpassed (Files=99, Tests=1237). The new regression was confirmed to fail against the unmodified getter.Split out of #603. This branch is based directly on
masterand can be reviewed and merged without another split PR.