Keep identifiers like handleInvalidInput in filter_leaf_nodes - #102
Open
StefanZoerner wants to merge 1 commit into
Open
Keep identifiers like handleInvalidInput in filter_leaf_nodes#102StefanZoerner wants to merge 1 commit into
StefanZoerner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filter_leaf_nodesrejects any candidate containingerror,exception,failedorinvalidas a substring, case-insensitively. The intent is to catch error strings that reach leaf-node selection instead of an identifier, but the check also silently discards ordinary names —handleInvalidInput,gameFailedCheck,ErrorLog.This matches on word boundaries instead, and only for candidates that are not known components: a string that resolves to a component cannot be an error message.
Adds
tests/test_leaf_selection.py; the function was previously uncovered. The test for identifier survival fails onmainand passes with this change.This is a part of #101, which I closed after the discussion there.