Repository navigation
Desktop: rows of a loaded chat are drawn when they come into view, no more blank bubbles (#497) - #498
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
… more blank bubbles (#497)
This was referenced Nov 17, 2026
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #497
Summary
Opening an existing chat could leave rows as empty slots: the bubble kept the height of its text but nothing was drawn in it (a user message showed as a big blank box with only Copy / Edit under it). Rows are now drawn again when they come into view.
Screenshots
None: the intermittent gaps could not be reproduced in the headless test driver, and I did not start VM 111. The blank-bubble state is the one the unit test below reproduces and the fix removes.
Technical details
perf/audit(Desktop: performance audit of November 2026, baseline and work packages #477 is still open). This PR must be retargeted todevonce Desktop: performance audit of November 2026, baseline and work packages #477 merges.measure+Hide), which flows the text in measure-only mode (no drawing objects,paintedWidthstays 0), andtranscriptLayout.LayoutthenShows the row and callsResizewith the size it already has. Fyne skips the layout for an unchanged size, so the text is never drawn, while its height stays in the row. Scrolling away and back (release) does the same. Fix:Layoutrefreshes a row that comes back from hidden.store/forget/sync/sumand tested that a changed height moves every following row by exactly the difference (TestTranscriptRowsFollowAChangedHeight); no defect found there. After load and after resizes, every row's stored height equals a fresh measure (TestTranscriptRowsKeepTheirHeight). So I found no evidence that Desktop: long chats: transcript layout, streamed markdown, scroll bench (#473) #486 caused the ~80 px gaps; the ~80 px gaps themselves are NOT reproduced and may need the real app (images/fonts loading late), so please do not close the issue on this alone unless the reporter confirms.devbuild (no gaps reproduced to compare); the hide-then-show design is the same indev.TestTranscriptRowsDrawAfterScrollingBack(fails before the fix), plus the two above.Assisted-by: Sonnet 5.5 low
🤖 Generated with Claude Code