Repository navigation
Themes: a theme can be one zip file with its shaders, fonts and licence (#499) - #500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499
Stacked on #495: this PR targets
feat/488-agent-themes; retarget it todevonce #495 merges.Summary
.zipin the themes folder (theme.toml, shaders, fonts, licence, optional preview, relative paths inside). One entry per zip in Settings; adding, replacing or removing a zip is picked up by the existing watcher..tomlthemes still work.theme_writenow writes<name>.zip(or replaces a theme where it already is, folder or loose); the format reference anddocs/THEMES.mddescribe the layout...refused (zip slip), links refused, at most 200 entries and 64 MB unpacked (also enforced on bytes actually read), only TOML, shaders, fonts, images and text/licence files; broken zips give plain-word errors.Screenshots
None: I did not run the app on VM 111 for this change; the Settings change is two extra buttons, covered by the loader tests.
Technical details
internal/palette/themepack.go: zip/folder loading,ReadThemeFile(zip entries read in memory viaarchive/zip, never extracted),PackTheme,UnpackTheme,WriteThemeZip(temp file + rename).internal/uigo throughpalette.ReadThemeFile. The folder watcher stamp now also covers files inside theme folders.Assisted-by: claude-sonnet-5-5 low
🤖 Generated with Claude Code