Repository navigation
Settings: the side panel's commands are drawn as soon as Settings closes (#492) - #502
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492
Summary
Tool commands in the right sidebar could stay blank after leaving Settings until something redrew the surface. Closing Settings now repaints the tool panel.
Screenshots
None: not reproduced visually (no VM 111 run); the blank paint only shows on a real GPU surface, and the headless test driver draws nothing.
Technical details
outputRenderer.place) while hidden, and a refresh of a hidden object is not queued for painting. OncloseNow, nothing re-queued them, so the commands waited for a stray redraw.toolPanel.redraw(internal/ui/toolpanel.go) re-places the wells, refreshes them and the panel view;settingsView.closeNowcalls it after the pane area is shown again.devwithout Desktop: nothing redraws when idle, cheaper theme changes (#474) #489, but Desktop: nothing redraws when idle, cheaper theme changes (#474) #489 removes the caret-blink redraw that masked this kind of missing repaint, so this fix is needed for Desktop: nothing redraws when idle, cheaper theme changes (#474) #489 not to make it worse. This PR does not depend on Desktop: nothing redraws when idle, cheaper theme changes (#474) #489 and is independent of it.TestSidePanelCommandsShownAfterSettingschecks the wells have visible rows after open/close Settings with a resize in between. It passes without the fix too (the Go state was already right), so it is a guard, not a reproduction of the paint problem.Assisted-by: Sonnet 5.5 low
🤖 Generated with Claude Code