Repository navigation
Conversation
The joints' discs turned the other way from the strokes' quads: the rasterizer adds signed areas, so each disc cut a hole where it met its stroke. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Opus 5.5 medium
Claude Code runs a Read sent with a command once the command is over. 1loop started both clocks at once: a Read that failed at once showed 1m59s. Calls are now started in Claude Code's order, and a result keeps the label of a call still running instead of 'Waiting for the model'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Opus 5.5 medium
It covered the whole window, title bar included: the window could no longer be moved, minimised, maximised or closed while it was open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Opus 5.5 medium
Rows were keyed by their label; two worktrees named 'base (detached)' shared a key and were laid on one place, leaving a hole above. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Opus 5.5 medium
The click takes the keyboard focus from the viewer; the window's own key handler now closes the picture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Opus 5.5 medium
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #533
Summary
base (detached)), the unfolded list showed an empty gap and one of them was missing. Both now show, with no gap.Screenshots
Linux shots: Xvfb at scale 1.4. Windows shots: a Windows 10 VM, with cross-built exes of
dev(c31a471) and of this branch. "Before" isdev, "After" is this branch. Every pair shows the same screen with the same saved state.base (detached), unfolded (Linux)In the last "Before", the click lands on the viewer's download button and opens "Save picture". In the "After", the window is maximised, and the viewer follows the new size under the title bar.
The tool-row timing and the activity label were not captured: that needs a live Claude Code session, which these test machines do not have. They are covered by the unit test below.
Technical details
internal/ui/chart_strokes.go,disc:golang.org/x/image/vector.Rasterizeradds signed areas, so the opposite winding cancelled out where a disc overlapped its quad.TestStrokeJointsAreSolid(usage_limits_test.go) checks the alpha at every joint at scales 1, 1.4 and 2. It fails 3 times on the old code.internal/ui/picture_viewer.goandinternal/ui/desktop.go:build()adds apictureLayerbetweenui.rootand the resize edges. Its layout,underTitleBar, places the viewer belowui.titleBar.openImageadds the viewer to this layer instead ofcanvas.Overlays(). A Fyne overlay is the only tree hit-tested while it is shown, so the title bar under it could never receive a click.closePicture()is called from the canvas'OnTypedKeyfor Escape: a click on the title bar takes the focus from the viewer.internal/ui/worktrees.goandinternal/ui/sidebar_groups.go:worktreeRowsnow also returns one key per row:path:<folder>for a worktree,foldandnewfor the other two rows.glideLayoutthen put both on the same target and left a hole.TestWorktreeRowsKeyedByFoldercovers it.internal/agent/claudecode.go:queue.claudeRunningmodels Claude Code's batching: consecutive concurrency-safe tools (Read, Grep, Glob, LS, WebFetch, WebSearch, ToolSearch, Task/Agent, TaskOutput) run together, and any other tool runs alone.tool_exec, and with it the start time, is emitted only when a call enters the running batch. Eachtool_resultstarts the next batch.TestClaudeRunningQueuecovers the batching.internal/ui/transcript.go: ontool_result, the "wait" activity is shown only when no other tool row is still running.gofmt,go vet ./...andgo test ./...pass, as does wasmgo vetofinternal/uiandcmd/1loop-web.Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code