Skip to content

Remote: attachments stay with their chat, pictures show as thumbnails - #549

Open
MopigamesYT wants to merge 1 commit into
devfrom
fix/543-544-remote-attachments
Open

MopigamesYT wants to merge 1 commit into
devfrom
fix/543-544-remote-attachments

Conversation

@MopigamesYT

Copy link
Copy Markdown
Member

Closes #544
Closes #543

What changed

Screenshots

Visible change: before/after screenshots still have to be attached (they couldn't be taken here, no desktop build).

Checked here: GOOS=js go vet ./internal/ui (tests compiled), cmd/1loop-web wasm build, go test ./internal/server. Not run here: the internal/ui tests and the desktop build (no C compiler or X11/GL headers in this environment); CI runs them.

Assisted-by: Claude Opus 5.5 medium

🤖 Generated with Claude Code

…#544, #543)

#544: selectChat dropped a server chat's uploaded files on every chat
switch, an upload that ended after the user moved on was lost, and a
failed send gave its files back only if its chat was still on screen.
switchAttachments now parks the server chat's files with the draft, as
it does for local chats (#409); uploads and failed sends that end while
another draft shows go to their own draft (parkServerFiles).

#543: a picture uploaded to a server chat showed as a name chip
("pasted-image.png"). The client keeps a thumbnail of each picture it
uploads (uploadThumbnail) and draws it with newPictureTile, which opens
the viewer and removes it like a local picture.

Test: TestServerAttachmentsBelongToTheirDraft.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants