Repository navigation
Remote: attachments stay with their chat, pictures show as thumbnails - #549
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
…#544, #543) #544: selectChat dropped a server chat's uploaded files on every chat switch, an upload that ended after the user moved on was lost, and a failed send gave its files back only if its chat was still on screen. switchAttachments now parks the server chat's files with the draft, as it does for local chats (#409); uploads and failed sends that end while another draft shows go to their own draft (parkServerFiles). #543: a picture uploaded to a server chat showed as a name chip ("pasted-image.png"). The client keeps a thumbnail of each picture it uploads (uploadThumbnail) and draws it with newPictureTile, which opens the viewer and removes it like a local picture. Test: TestServerAttachmentsBelongToTheirDraft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #544
Closes #543
What changed
selectChatno longer drops a server chat's uploaded files.switchAttachmentsparks them with the draft, as it does for local chats (Pasted images are kept across chats, unlike chat drafts #409). Uploads and failed sends that finish while another draft is on screen go to their own draft (parkServerFiles).uploadThumbnail, read again from here, max 25 MB), andrenderAttachmentsdraws it withnewPictureTile(opens the viewer, × removes it) instead of a name chip. Other files keep their chip.TestServerAttachmentsBelongToTheirDraft.Screenshots
Visible change: before/after screenshots still have to be attached (they couldn't be taken here, no desktop build).
Checked here:
GOOS=js go vet ./internal/ui(tests compiled),cmd/1loop-webwasm build,go test ./internal/server. Not run here: theinternal/uitests and the desktop build (no C compiler or X11/GL headers in this environment); CI runs them.Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code