Repository navigation
Transcript: streamed answers no longer drawn over the next row (#440) - #557
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
A rebuilt Markdown block gave its height at a provisional width (600 px) before flowing at its own, and the answer was laid out with that height: a list kept gaps between its items and its end was drawn below the answer, under the next row, whenever the answer's height did not change and nothing laid it out again. ParseMarkdown now lays out again until each block is as high as it measures. Tests: TestStreamedAnswerDoesNotOverlap (fails before the fix), TestLoadedAnswerDoesNotOverlap; go test ./internal/ui passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Tried in the real app, on the linux-test VM (Plasma Wayland, 1280×800). The mock model streamed a list answer word by word, followed by a second message.
So:
Assisted-by: Claude Opus 5.5 medium |
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #440 (in the real app this alone was not shown to be the cause; see the comment below)
What changed
ParseMarkdownlays the answer's blocks out again until each one is as high as it measures. A rebuilt block first reported its height at a provisional 600 px width (flowRenderer.MinSize) and was placed with it. A list then kept large gaps between its items, and its end was drawn below the answer, over the next row (Copy row, tool rows, the next message). Nothing corrected it when the answer's total height had not changed, which is frequent while words are added to a line.internal/ui/transcript_overlap_test.gocheck that no part of the transcript reaches past what holds it or crosses another part:TestStreamedAnswerDoesNotOverlapstreams an answer word by word (lists, a nested list, a code block). It fails before the fix ("ends at 74.2, below its holder (50.2)").TestLoadedAnswerDoesNotOverlapcovers an answer of a chat being opened. It already passed before the fix and is kept as a guard.Screenshots
Before/after screenshots of a streamed list answer are still to be attached.
Checked here:
go test ./internal/ui(whole package, Fyne test driver, built with zig cc),go vet,gofmt. Not run here:-race, the real app.Related: #497 (the opposite symptom, gaps between rows of a loaded chat) may share part of this cause, but this PR does not claim to fix it.
Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code