Skip to content

Side panel: Open on GitHub opens the browser (#441) - #558

Open
MopigamesYT wants to merge 1 commit into
devfrom
fix/441-open-on-github
Open

MopigamesYT wants to merge 1 commit into
devfrom
fix/441-open-on-github

Conversation

@MopigamesYT

Copy link
Copy Markdown
Member

Closes #441

What changed

  • "Open on GitHub" in the side panel's GitHub tab opens the default browser. It called openLink, which shows any issue or pull request address in the side panel, so it showed the same page again. This was not specific to GNOME or the .deb.
  • The worktree menu's "Open pull request #N" had the same problem and now opens the browser too.
  • openInBrowser (in flowtext.go) opens any web or mail address without that detection. It merges the helper of the same name used for images and videos. Links to issues inside chat text still open in the side panel.

Screenshots

Nothing visible: no screenshots.

Checked here: go test ./internal/ui (whole package), go vet, gofmt; TestOpenOnGitHubOpensTheBrowser fails before the fix. Not run here: a real browser opening from the app.

Assisted-by: Claude Opus 5.5 medium

🤖 Generated with Claude Code

The button went through openLink, which shows an issue or pull request
address in the side panel, so it showed the same page again and never
reached the browser. Buttons meant for the browser (Open on GitHub, the
worktree's Open pull request, images) now use openInBrowser, which opens
any web or mail address. The image helper of the same name is merged
into it.

Tests: TestOpenOnGitHubOpensTheBrowser (fails before the fix).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants