Repository navigation
Side panel: Open on GitHub opens the browser (#441) - #558
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
The button went through openLink, which shows an issue or pull request address in the side panel, so it showed the same page again and never reached the browser. Buttons meant for the browser (Open on GitHub, the worktree's Open pull request, images) now use openInBrowser, which opens any web or mail address. The image helper of the same name is merged into it. Tests: TestOpenOnGitHubOpensTheBrowser (fails before the fix). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #441
What changed
openLink, which shows any issue or pull request address in the side panel, so it showed the same page again. This was not specific to GNOME or the .deb.openInBrowser(inflowtext.go) opens any web or mail address without that detection. It merges the helper of the same name used for images and videos. Links to issues inside chat text still open in the side panel.Screenshots
Nothing visible: no screenshots.
Checked here:
go test ./internal/ui(whole package),go vet,gofmt;TestOpenOnGitHubOpensTheBrowserfails before the fix. Not run here: a real browser opening from the app.Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code