Repository navigation
Sidebar: a project's branch never covers its name (#469) - #560
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
A row's trailing text (a project's branch) was always drawn whole from the row's end, and only the name was cut for it; with no room left, fitText kept the whole name, drawn over the branch. The name now comes first: the trailing text gets what it leaves, cut short with an ellipsis, then hidden, and the name is cut only once it is gone. The row's mark goes before the trailing text is cut. Tests: TestRowNameBeforeBranch (fails before the fix); TestRowMarkStepsAside still passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
What changed
fitText(which keeps everything at width 0) gave back the whole name, drawn over the branch.TestRowMarkStepsAsideexpects.Screenshots
Taken on the linux-test VM: a project
1looponfeat/discord-presence, the sidebar at 230, 200 and 180 px;devon the left, this PR on the right.Checked here:
go test ./internal/ui(whole package),go vet,gofmt.TestRowNameBeforeBranchlays a "1loop" row with branchfeat/discord-presenceout at every width from 320 to 60 px, and fails before the fix ("1lo…" next to the whole branch). Run in the real app on the linux-test VM (screenshots above).Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code