Repository navigation
Terminal: one folder check for terminal_tabs on desktop and server (#526) - #562
Open
MopigamesYT wants to merge 1 commit into
Open
MopigamesYT wants to merge 1 commit into
MopigamesYT wants to merge 1 commit into
Conversation
) On an SSH machine the server resolved a terminal's cwd with MachinePath (links followed over SFTP), while the desktop only joined the path and compared its prefix: a link in the project that led outside it was refused on one and accepted on the other. agent.TerminalDir now does it for both. The desktop resolves the folder before its UI callback, since it is looked up on the machine. Tests: TestTerminalDirOnAMachine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tpm28
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #526
What changed
agent.TerminalDirgives the folderterminal_tabsopens a terminal in:cwdis given;MachinePath, which resolves links there, so one can't lead outside the project;WorkspacePath.Screenshots
Nothing visible: no screenshots.
Checked here:
go test ./internal/agent ./internal/server ./internal/ui,go build ./...,go vet,gofmt.TestTerminalDirOnAMachineuses a fake machine backed by local folders and covers a link out of the project,.., a folder inside it, and nocwd. Not run here: a real SSH machine. There is no desktop-level test of the tool itself.Assisted-by: Claude Opus 5.5 medium
🤖 Generated with Claude Code