Skip to content

Settings: the theme file controls are part of the Theme row (#508) - #563

Open
MopigamesYT wants to merge 1 commit into
devfrom
fix/508-theme-file-row
Open

MopigamesYT wants to merge 1 commit into
devfrom
fix/508-theme-file-row

Conversation

@MopigamesYT

@MopigamesYT MopigamesYT commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Closes #508

What changed

  • The theme files' note and the New theme, Duplicate, (Edit) and Open folder buttons are now the end of the Theme row in Settings → General → Appearance. They were a card row of their own.
    • They use the row's 16 px inset, the same as the title and description. The buttons used to sit against the card's edge.
    • The note uses the row's description style (12.5, muted). It used to be a faint LowImportance label that looked disabled.
  • The card's divider now comes after them, before "Accent colour".
  • Errors from unreadable theme files still show under the buttons, in red.

Screenshots

Taken on the linux-test VM, Settings → General → Appearance.

dev this PR
dev: the buttons sit against the card's edge, the note is faint this PR: the note and buttons line up with the Theme row

Checked here: go test ./internal/ui (whole package), go vet, gofmt. TestThemeFileControlsLineUp checks that the note and New theme start at the Theme title's x and belong to the Theme row. It does not compile on the old code, since the function was renamed, so I did not run it before the fix. Run in the real app on the linux-test VM (screenshots above).

Note: #495 adds buttons to the same HBox. It will need a rebase on themeFileControls.

Assisted-by: Claude Opus 5.5 medium

🤖 Generated with Claude Code

The note about theme files and the New theme, Duplicate and Open folder
buttons were a card row of their own, without settingRow's inset: the
buttons sat against the card's edge, the note started elsewhere, ran the
card's width and was drawn faint, as if disabled. They are now the end
of the Theme row, inset as its text, the note in the row's description
style, and the card's divider follows them, before Accent colour.

Tests: TestThemeFileControlsLineUp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants