Skip to content

refactor(experiments): drop conversions chart mode toggle - #8484

Open
Zaimwa9 wants to merge 1 commit into
mainfrom
refactor/conversions-chart-cumulative-only
Open

refactor(experiments): drop conversions chart mode toggle#8484
Zaimwa9 wants to merge 1 commit into
mainfrom
refactor/conversions-chart-cumulative-only

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Removes the cumulative/daily toggle from the experiment "Conversions over time" chart — the chart is now always cumulative.

  • Drops InlinePillToggle and its mode state from ExperimentConversionRateCard.
  • Drops ConversionMode and the mode argument from buildConversionChartData; AccumulatedBucket no longer tracks per-bucket increments.
  • Series labels are always "<variant> converted".

How did you test this code?

Updated deriveConversionRate unit tests (daily case removed); results/__tests__ passes, 85 tests. Checked the card renders the cumulative series with the toggle gone.

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Sep 8, 2026 1:59pm UTC
flagsmith-frontend-staging Ready Ready Preview Sep 8, 2026 1:59pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Sep 8, 2026 1:59pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4d8df846-7c3a-4b16-94d5-dd1821292a7d

📥 Commits

Reviewing files that changed from the base of the PR and between e5a1ec0 and b4969aa.

📒 Files selected for processing (3)
  • frontend/web/components/experiments/results/ExperimentConversionRateCard/ExperimentConversionRateCard.tsx
  • frontend/web/components/experiments/results/__tests__/deriveConversionRate.test.ts
  • frontend/web/components/experiments/results/deriveConversionRate.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The conversion chart now produces cumulative converted totals only. The daily conversion mode, per-bucket increment data, mode state, and cumulative/daily toggle were removed. Chart construction no longer accepts a mode argument. Tests now use the default cumulative behaviour and no longer cover daily series output.

Priority: ⬇️ Low — Defer this narrow experiment chart refactor because it only removes the daily conversion toggle and keeps cumulative data display.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b4969

The conversions chart now always displays cumulative converted totals, with the daily toggle and daily-series behavior removed. The implementation and tests are aligned with this behavior.

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard refactor labels Sep 8, 2026
@Zaimwa9
Zaimwa9 marked this pull request as ready for review September 8, 2026 13:59
@Zaimwa9
Zaimwa9 requested a review from a team as a code owner September 8, 2026 13:59
@Zaimwa9
Zaimwa9 requested review from talissoncosta and removed request for a team September 8, 2026 13:59
@github-actions github-actions Bot added refactor and removed refactor labels Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8484 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8484 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8484 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8484 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8484 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-8484 Finished ✅ Results

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #20293 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.6 seconds
commit  b4969aa
info  🔄 Run: #20293 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20293 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 17 seconds
commit  b4969aa
info  🔄 Run: #20293 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20293 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.3 seconds
commit  b4969aa
info  🔄 Run: #20293 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #20293 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.1 seconds
commit  b4969aa
info  🔄 Run: #20293 (attempt 1)

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants