refactor(experiments): drop conversions chart mode toggle - #8484
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe conversion chart now produces cumulative converted totals only. The daily conversion mode, per-bucket increment data, mode state, and cumulative/daily toggle were removed. Chart construction no longer accepts a mode argument. Tests now use the default cumulative behaviour and no longer cover daily series output. Priority: ⬇️ Low — Defer this narrow experiment chart refactor because it only removes the daily conversion toggle and keeps cumulative data display. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The conversions chart now always displays cumulative converted totals, with the daily toggle and daily-series behavior removed. The implementation and tests are aligned with this behavior. Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-16 — run #20293 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20293 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20293 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20293 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Removes the cumulative/daily toggle from the experiment "Conversions over time" chart — the chart is now always cumulative.
InlinePillToggleand its mode state fromExperimentConversionRateCard.ConversionModeand themodeargument frombuildConversionChartData;AccumulatedBucketno longer tracks per-bucket increments."<variant> converted".How did you test this code?
Updated
deriveConversionRateunit tests (daily case removed);results/__tests__passes, 85 tests. Checked the card renders the cumulative series with the toggle gone.