Skip to content

[BUGFIX] Fix non-existent mod icons breaking scanMods chain #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbnormalPoof merged 1 commit into from
Oct 23, 2026
+3 −3
Merged

[BUGFIX] Fix non-existent mod icons breaking scanMods chain #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polymod/fs/BaseFileSystem.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ abstract class BaseFileSystem implements IFileSystem

var iconFile = getModIconPath(modPath, origin);

if (exists(iconFile))
if (iconFile != null && exists(iconFile))
{
var iconBytes:Null<Bytes> = getFileBytes(iconFile);

Expand Down Expand Up @@ -370,7 +370,7 @@ abstract class BaseFileSystem implements IFileSystem

var iconFile = getModIconPath(modPath, origin);

if (exists(iconFile))
if (iconFile != null && exists(iconFile))
{
var iconBytes:Null<Bytes> = getFileBytes(iconFile);

Expand Down
2 changes: 1 addition & 1 deletion polymod/fs/SysZipFileSystem.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class SysZipFileSystem extends SysFileSystem

var iconFile = getModIconPath(modId, origin);

if (exists(iconFile))
if (iconFile != null && exists(iconFile))
{
var iconBytes:Null<Bytes> = getFileBytes(iconFile);

Expand Down
Loading