Repository navigation
[BUGFIX] Catch invalid dependency versions and treat empty strings as any version - #565
Merged
Merged
Conversation
second fix is to match what is said here https://github.com/FunkinCrew/polymod/blob/develop/docs/docs/dependencies.markdown (credits to ComedyLost for pointing this out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
a mod with an invalid dependency version would throw while reading the metadata and stop all other mods from loading, it now just skips over that mod with an error
empty strings for dependency versions also threw even though the docs say they should work the same as
*. they are now treated as*so the mods can load. all credit to @ComedyLost for pointing this outExample of Bug
mods working fine
bad value added in evil mod
none of the mods work!!!
