build(deps): patch brace-expansion DoS - #38
Merged
Merged
Conversation
Owner
Author
|
Local proof from
|
GSTJ
added a commit
that referenced
this pull request
Sep 21, 2026
* fix(release): bump a patch for build(deps) commits Three security patches (#37, #38, #43, #44, #45) landed as build(deps): commits and never reached npm: the changelog preset marks build as effect: "changelog", so release-it correctly found nothing to release and exited 0 every time. Nobody was watching for that, so the patches sat on master. findTypeEntry matches on type and scope before falling back to the scope-less entry, so a build(deps) entry ahead of the generic build one in TYPES lets dependency and security patches bump a patch while scope-less build: (tooling, tsconfig, oxfmt) still doesn't move the version. changelog-check.mjs's POLICY and assertions are updated to match, including a build(deps) vs build bump test so this can't regress silently again. * docs: the Swift AppDelegate redirect already landed bb07d7b fixed the SDK 53+ AppDelegate.swift bundle URL redirect back in v1.0.13, but the SDK-support note above it was written 26 minutes earlier the same day and never got updated. Confirmed by prebuild against a fresh SDK 57 app: CodePush.bundleURL() lands in ReactNativeDelegate.bundleURL() same as the Objective-C template does. * style: satisfy oxfmt on changelog-check.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We pinned both vulnerable
brace-expansionbranches to their patched releases, clearing GHSA-rgw5-rvv9-x895 from the development dependency graph.Details
1.xnow resolves to1.1.18.5.xnow resolves to5.0.9.Testing steps
pnpm install --frozen-lockfile pnpm audit pnpm test --runInBand npm pack --dry-runEach command should exit successfully. The audit should report no known vulnerabilities.