Repository navigation
Fix: trim whitespace around the Content-Type parameter separator - #49
Merged
Garados007 merged 1 commit intoOct 4, 2026
Merged
Conversation
RFC 9110 allows optional whitespace before the `;`, so a header such as `multipart/form-data ; boundary=x` left a trailing space in the media type. The DataHandler lookup then missed and the body was stored as RawPostData instead of being parsed. Fixes Garados007#36 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
:) |
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
Content-Type: multipart/form-data ; boundary=x(optional whitespace before;is allowed by RFC 9110) leftMimeTypeas"multipart/form-data ". TheDataHandlerlookup missed, so the body was stored asRawPostDatainstead of being parsed.Change:
HttpPost.SetPostnow trims the media type and the parameter part after splitting on;.Tests (
TestHttpPost):; charset=utf-8resolves toUrlEncodedDataand a trimmedMimeTypemultipart/form-data ; boundary=xis parsed into its entriesBoth fail on
mainand pass with the fix. Full suite passes on net8.0 and net10.0.🤖 Generated with Claude Code