Repository navigation
Fix: compare the WebSocket Upgrade header case-insensitively - #51
Merged
Garados007 merged 1 commit intoOct 4, 2026
Merged
Conversation
RFC 6455 section 4.2.1 says the Upgrade value is case-insensitive. A client sending `Upgrade: WebSocket` failed the `== "websocket"` check and fell through to normal HTTP handling. Fixes Garados007#48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
RFC 6455 section 4.2.1 says the
Upgradevalue is case-insensitive, butWebSocketService.CanWorkWithcompared it with== "websocket". A client sendingUpgrade: WebSocketnever got the handshake and fell through to normal HTTP handling (usually a 404).Change: compare with
string.Equals(..., StringComparison.OrdinalIgnoreCase), matching the existingConnectioncheck on the same line.Tests (
TestWebSocketService):CanWorkWithacceptswebsocket,WebSocketandWEBSOCKET(the latter two fail onmain)CanWorkWithstill rejects a different upgrade (h2c)Full suite passes on net8.0 and net10.0.
🤖 Generated with Claude Code