Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The manifest becomes a workspace of one. [workspace.package] holds the edition and the promised rust-version, [workspace.lints] holds the lint table, and the crate inherits all three, so a toolchain change moves one line. tools/ is excluded, so accuracy-bench stays a standalone crate. The lint table also denies unsafe_op_in_unsafe_fn, undocumented_unsafe_blocks, multiple_unsafe_ops_per_block and iter_over_hash_type. None of them fires: the crate has no unsafe code and no hash collections. [package.metadata.check] no_panic_coverage = ["src/ops"] records which code the no-panic proof must cover: every public function there carries #[no_panic] and is called from the verify_no_panic binary. All 26 do. Cargo ignores the table, and the published package is unchanged.
GeEom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest becomes a workspace of one:
[workspace.package]holds the edition and the promisedrust-version(1.95), and[workspace.lints]holds the lint table.tools/is excluded from the workspace, so accuracy-bench stays a standalone crate.The lint table also denies
unsafe_op_in_unsafe_fn,undocumented_unsafe_blocks,multiple_unsafe_ops_per_blockanditer_over_hash_type. None fires: the crate has no unsafe code and no hash collections.[package.metadata.check] no_panic_coverage = ["src/ops"]records which code the no-panic proof must cover. Every public function there carries#[no_panic]and is called from theverify_no_panicbinary, and all 26 do. Cargo ignores the table.The published package is unchanged, since cargo resolves inherited
editionandrust-versionwhen packaging.