Repository navigation
feat(sites): add restore command and deleted listing - #12
Merged
Merged
Conversation
vigneshrajsb
marked this pull request as ready for review
October 9, 2026 22:23
Regenerated with pnpm generate:api; only the Sites types this change uses are committed.
Add lfc sites restore <id> and lfc sites list --deleted, show how long deleted sites are kept (from sites capabilities), and point delete output at restore. The delete prompt only promises a restore window when the server reports one.
vigneshrajsb
force-pushed
the
sites-restore
branch
from
October 9, 2026 22:36
d1ce348 to
872ab70
Compare
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on GoodRxOSS/lifecycle#256 (site soft delete). Merge after it ships.
lfc sites restore <id>: restores a deleted site at the same id and URL. The revision comes from the deleted list, becauseGET /sites/{id}returns 404 for deleted sites.lfc sites list --deleted: shows your restorable sites, when each stops being restorable, and how long deleted sites are kept (fromdeletedRetentionDaysin sites capabilities).--deletedimplies--mineand can't be combined with--public.lfc sites delete: the prompt says how many days the site can be restored, and the output says until whenlfc sites restorewill work.lfc llmsand the README are updated.site,sitePermissions,siteStatus,listSitesView,listSitesParams,sitesCapabilities), taken unmodified frompnpm generate:api. The rest of the regenerated backlog is left out for now.Test plan
pnpm lint,pnpm typecheck,pnpm test,pnpm format:checkpass, with new tests for restore,list --deleted, flag combinations, and the delete message.lfc sites list --deleted,lfc sites restore <id>, and check the original URL works again.