Skip to content

chore(eventarc): update dependencies - #4459

Open
angelcaamal wants to merge 2 commits into
mainfrom
chore/update-eventarc-deps
Open

angelcaamal wants to merge 2 commits into
mainfrom
chore/update-eventarc-deps

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/559306081

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. asset: pattern DEE Asset tagging - Pattern. labels Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies (express to ^5.0.0 and c8 to ^12.0.0) and Node.js engine requirements (>=20.0.0) across several Eventarc sample packages. Feedback was provided to also update the engines.node field in eventarc/generic/package.json to >=20.0.0 to maintain consistency and compatibility with the upgraded c8 package.

Comment thread eventarc/generic/package.json
@amcolin
amcolin marked this pull request as ready for review September 10, 2026 18:03
@amcolin
amcolin requested review from a team as code owners September 10, 2026 18:03

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: eventarc Issues related to the Eventarc API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants