Skip to content

chore(recaptcha_enterprise): update dependencies - #4460

Open
angelcaamal wants to merge 4 commits into
mainfrom
deps-recaptcha-enterprise
Open

angelcaamal wants to merge 4 commits into
mainfrom
deps-recaptcha-enterprise

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/560164191
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: recaptchaenterprise Issues related to the reCAPTCHA API. asset: flagship DEE Asset tagging - Flagship. labels Sep 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine target to >=20.0.0 and upgrades various dependencies and devDependencies across the project's package.json files. The review feedback correctly identifies that several of the specified dependency versions (specifically body-parser v2, @types/node v24, c8 v12, and eslint v10) do not exist on the npm registry and would cause installation failures. Actionable suggestions are provided to revert or pin these to valid, stable versions.

Comment thread recaptcha_enterprise/snippets/package.json
Comment thread recaptcha_enterprise/snippets/package.json
Comment thread recaptcha_enterprise/snippets/package.json
Comment thread recaptcha_enterprise/snippets/package.json
@amcolin
amcolin marked this pull request as ready for review September 11, 2026 16:48
@amcolin
amcolin requested review from a team as code owners September 11, 2026 16:48

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: recaptchaenterprise Issues related to the reCAPTCHA API. asset: flagship DEE Asset tagging - Flagship. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants