chore(spanner): update dependencies - #4466
angelcaamal wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the required Node engine version to >=20 and upgrades several OpenTelemetry dependencies along with chai in spanner/package.json. The review feedback correctly identifies two critical issues: a non-existent version typo for @opentelemetry/core (^2.30.1) and a breaking upgrade of chai to v6.0.0 which is ESM-only and incompatible with this CommonJS project.
| "@opentelemetry/core": "^1.30.1", | ||
| "chai": "^4.2.0", | ||
| "@opentelemetry/core": "^2.30.1", | ||
| "chai": "^6.0.0", |
There was a problem hiding this comment.
Chai v5 and above (including v6.0.0) are ESM-only. Since this project is configured as CommonJS (lacking "type": "module" in package.json), upgrading to chai v6.0.0 will cause tests to fail with ERR_REQUIRE_ESM when using require('chai'). Please keep chai at ^4.2.0 or migrate the project to ESM in a separate PR.
| "chai": "^6.0.0", | |
| "chai": "^4.2.0", |
| "@opentelemetry/api": "^1.9.0", | ||
| "@opentelemetry/core": "^1.30.1", | ||
| "chai": "^4.2.0", | ||
| "@opentelemetry/core": "^2.30.1", |
There was a problem hiding this comment.
The version ^2.30.1 for @opentelemetry/core does not exist on the npm registry. It appears to be a typo from changing the major version from 1 to 2 while keeping the minor/patch versions (1.30.1 -> 2.30.1). Please revert this to ^1.30.1 to avoid installation errors.
| "@opentelemetry/core": "^2.30.1", | |
| "@opentelemetry/core": "^1.30.1", |
References
- Verify the existence and stability of package versions on the npm registry before flagging them as invalid or pre-release.
Description
Fixes b/560283564
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.