Skip to content

chore(spanner): update dependencies - #4466

Draft
angelcaamal wants to merge 1 commit into
mainfrom
deps-spanner
Draft

angelcaamal wants to merge 1 commit into
mainfrom
deps-spanner

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/560283564

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Sep 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the required Node engine version to >=20 and upgrades several OpenTelemetry dependencies along with chai in spanner/package.json. The review feedback correctly identifies two critical issues: a non-existent version typo for @opentelemetry/core (^2.30.1) and a breaking upgrade of chai to v6.0.0 which is ESM-only and incompatible with this CommonJS project.

Comment thread spanner/package.json
"@opentelemetry/core": "^1.30.1",
"chai": "^4.2.0",
"@opentelemetry/core": "^2.30.1",
"chai": "^6.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Chai v5 and above (including v6.0.0) are ESM-only. Since this project is configured as CommonJS (lacking "type": "module" in package.json), upgrading to chai v6.0.0 will cause tests to fail with ERR_REQUIRE_ESM when using require('chai'). Please keep chai at ^4.2.0 or migrate the project to ESM in a separate PR.

Suggested change
"chai": "^6.0.0",
"chai": "^4.2.0",

Comment thread spanner/package.json
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/core": "^1.30.1",
"chai": "^4.2.0",
"@opentelemetry/core": "^2.30.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version ^2.30.1 for @opentelemetry/core does not exist on the npm registry. It appears to be a typo from changing the major version from 1 to 2 while keeping the minor/patch versions (1.30.1 -> 2.30.1). Please revert this to ^1.30.1 to avoid installation errors.

Suggested change
"@opentelemetry/core": "^2.30.1",
"@opentelemetry/core": "^1.30.1",
References
  1. Verify the existence and stability of package versions on the npm registry before flagging them as invalid or pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant