chore: Updating Debian 11 to 13 - #4468
m-strzelczyk wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the default Debian image version from debian-11 to debian-13 across various Compute Engine, Batch, and Cloud Functions samples and tests. The review feedback points out that several files incorrectly include a trailing slash at the end of the debian-13 image family URI, which deviates from standard Google Cloud resource paths and should be removed to prevent potential API resolution issues.
| diskSizeGb: '64', | ||
| sourceImage: | ||
| 'projects/debian-cloud/global/images/family/debian-11/', | ||
| 'projects/debian-cloud/global/images/family/debian-13/', |
There was a problem hiding this comment.
The source image family URI should not end with a trailing slash. Standard Google Cloud resource paths do not include a trailing slash, and keeping it might lead to API resolution issues or inconsistency with other samples.
| 'projects/debian-cloud/global/images/family/debian-13/', | |
| 'projects/debian-cloud/global/images/family/debian-13', |
| diskSizeGb: '64', | ||
| sourceImage: | ||
| 'projects/debian-cloud/global/images/family/debian-11/', | ||
| 'projects/debian-cloud/global/images/family/debian-13/', |
There was a problem hiding this comment.
The source image family URI should not end with a trailing slash. Standard Google Cloud resource paths do not include a trailing slash, and keeping it might lead to API resolution issues or inconsistency with other samples.
| 'projects/debian-cloud/global/images/family/debian-13/', | |
| 'projects/debian-cloud/global/images/family/debian-13', |
| diskSizeGb: '64', | ||
| sourceImage: | ||
| 'projects/debian-cloud/global/images/family/debian-11/', | ||
| 'projects/debian-cloud/global/images/family/debian-13/', |
There was a problem hiding this comment.
The source image family URI should not end with a trailing slash. Standard Google Cloud resource paths do not include a trailing slash, and keeping it might lead to API resolution issues or inconsistency with other samples.
| 'projects/debian-cloud/global/images/family/debian-13/', | |
| 'projects/debian-cloud/global/images/family/debian-13', |
| diskSizeGb: '64', | ||
| sourceImage: | ||
| 'projects/debian-cloud/global/images/family/debian-11/', | ||
| 'projects/debian-cloud/global/images/family/debian-13/', |
There was a problem hiding this comment.
The source image family URI should not end with a trailing slash. Standard Google Cloud resource paths do not include a trailing slash, and keeping it might lead to API resolution issues or inconsistency with other samples.
| 'projects/debian-cloud/global/images/family/debian-13/', | |
| 'projects/debian-cloud/global/images/family/debian-13', |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.