build(multiple samples): bump Django to 6.1.1 in requirements - #14575
build(multiple samples): bump Django to 6.1.1 in requirements#14575XrossFox wants to merge 1 commit into
Conversation
Updates the Django dependency to version 6.1.1 for Python 3.12+ across App Engine, Kubernetes Engine, and Cloud Run tutorials to resolve Dependabot alerts.
There was a problem hiding this comment.
Code Review
This pull request attempts to upgrade the Django dependency version from 6.0.x to 6.1.1 across several requirements.txt files. The reviewer correctly identified a critical issue: Django 6.x is not yet released, and these version numbers are systematic typos for 5.0.x and 5.1.1. Using 6.1.1 will cause pip installation to fail since the version does not exist on PyPI. The reviewer suggested correcting the dependency to Django 5.1.1.
| @@ -1,4 +1,4 @@ | |||
| Django==6.0.5; python_version >= "3.12" | |||
| Django==6.1.1; python_version >= "3.12" | |||
There was a problem hiding this comment.
It appears there is a systematic version number typo. Django 6.x has not been released yet (the current stable series is Django 5.1.x). The previous version 6.0.5 was likely a typo for 5.0.5, and this bump to 6.1.1 is a typo for 5.1.1. Specifying 6.1.1 will cause pip install to fail because the version does not exist on PyPI.
Django==5.1.1; python_version >= "3.12"
There was a problem hiding this comment.
Most up-to date version of django available on pypi is 6.1.1.
Description
Updates the Django dependency to version 6.1.1 for Python 3.12+ across App Engine, Kubernetes Engine, and Cloud Run tutorials to resolve Dependabot alerts.
Fixes b/557225598
Checklist
Testing
Compliance & Style
Post-Approval Actions