Skip to content

Bound annual burndown bars to supported calendar years - #4227

Merged
djmitche merged 1 commit into
GothenburgBitFactory:developfrom
jatinninety9:fix/burndown-date-boundary
Nov 15, 2026
Merged

djmitche merged 1 commit into
GothenburgBitFactory:developfrom
jatinninety9:fix/burndown-date-boundary

Conversation

@jatinninety9

Copy link
Copy Markdown
Contributor

Related to #4224; follow-up to #4226 for annual charts with drawable dimensions.

An annual chart at width 200 requests 61 yearly bars. Starting in 2026, generation reaches a year below the calendar constructor's supported minimum of 1969 and asserts. Even a request ending exactly at 1969 attempts an unused decrement into 1968 after generating its last bar.

Cap the annual bar count at the number of supported years through the current year, and calculate a previous period only when another bar is needed. The chart keeps its terminal dimensions and renders the available supported history. Other periods retain their existing bar counts.

The regression freezes the clock in 1970 and 2026 and checks widths 80, 189, 200, and 1015. The 1970 cases also verify that both 1969 and 1970 labels remain visible. Seven of the eight cases fail before the production change; the 2026 normal-width control already passes.

Validation:

  • All ten burndown test methods pass after the change.
  • GCC Debug build in WSL Ubuntu; full CTest run: 179/179 entries passed with a 600-second per-entry timeout. Existing skipped/expected-failure subtests remain.
  • The isolated 312-case dimensions matrix now completes with zero failures, including the eight annual failures remaining after Reject invalid burndown dimensions before generating bars #4226.
  • clang-format 21.1.8, Black 25.12.0, and git diff --check pass.

@djmitche djmitche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This command hasn't seen this much attention in a loooong time!

@djmitche
djmitche merged commit 357c95a into GothenburgBitFactory:develop Nov 15, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants