Repository navigation
Conversation
djmitche
approved these changes
Nov 15, 2026
djmitche
left a comment
Member
There was a problem hiding this comment.
Thanks!
This command hasn't seen this much attention in a loooong time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4224; follow-up to #4226 for annual charts with drawable dimensions.
An annual chart at width 200 requests 61 yearly bars. Starting in 2026, generation reaches a year below the calendar constructor's supported minimum of 1969 and asserts. Even a request ending exactly at 1969 attempts an unused decrement into 1968 after generating its last bar.
Cap the annual bar count at the number of supported years through the current year, and calculate a previous period only when another bar is needed. The chart keeps its terminal dimensions and renders the available supported history. Other periods retain their existing bar counts.
The regression freezes the clock in 1970 and 2026 and checks widths 80, 189, 200, and 1015. The 1970 cases also verify that both 1969 and 1970 labels remain visible. Seven of the eight cases fail before the production change; the 2026 normal-width control already passes.
Validation:
git diff --checkpass.