Repository navigation
Prefer detected terminal width over configured defaults - #4230
Open
jatinninety9 wants to merge 2 commits into
Open
jatinninety9 wants to merge 2 commits into
jatinninety9 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4224.
Follow the reporter's proposed ordering and the maintainer's agreement in the issue discussion: use a usable detected terminal width first, then fall back to
defaultwidth. Previously,defaultwidth=0returned 65,536 before terminal detection, so burndown reports rejected even a normal-sized terminal as too large.Preserve the configured fallback when detection produces no usable width, treat negative defaults like zero, and apply
avoidlastcolumnonly to detected widths. Update the man page for negative defaults.Add 14 C++ regression cases covering detection, fallback, nonpositive defaults and
avoidlastcolumn. Give the existing view-rendering test an explicit width so its wrapping assertion is independent of terminal detection.Validation:
defaultwidth=0in a 120x24 pseudo-terminal; positive-default controls also pass.All runtime probes used temporary task data. Other platform builds remain for upstream CI.