更新模组时允许选择目标版本并预览对应更新日志 by ZZZank · Pull Request #6747 · HMCL-dev/HMCL

ZZZank · 2026-08-26T14:49:13Z

以下演示稍显过时了，现在在选择框里选择版本可以改变实际会更新到的目标版本，文本也有变化。

得益于检查更新时已经收集过所有比当前更加新的模组版本了，最复杂的部分可以跳过，只考虑实现一个界面。

2026-08-26.223311.mp4

语言文件和第一个提交由AI生成。

fixes #6686

Co-authored-by: mimo-v2.5

`I18N_zh_CN.properties: misspelled '其它' should be replaced by '其他'` from `gradle checkTranslations`

Glavo · 2026-08-27T13:44:38Z

这里不需要说“查看其他版本的游戏日志”啊，你直接说这里是“游戏版本”不就行了吗？

3gf8jv4dv · 2026-08-27T13:50:48Z

这里不需要说“查看其他版本的游戏日志”啊，你直接说这里是“游戏版本”不就行了吗？

感觉 “游戏版本” 也不太好，应该是 “模组版本” 吧？

ToobLac · 2026-08-28T14:34:27Z

感觉 “游戏版本” 也不太好，应该是 “模组版本” 吧？

不是模组啊，资源包也可以检查更新的，光影包也有计划做

ToobLac · 2026-08-28T14:35:10Z

你确定这样不会oom吗，我记得 tnt 之前专门把这一堆候选给删掉了，因为会爆内存

以及你为什么要把 remoteVersions 和 remoteVersions.get(0) 都存在 AddonUpdate 里面呢？只存列表不就行了吗？

3gf8jv4dv · 2026-08-28T14:35:28Z

不是模组啊，资源包也可以检查更新的，光影包也有计划做

当时看 glavo 似乎说错了，写的太快没想太多 🤣

ZZZank · 2026-08-28T15:01:39Z

所以有没有比较好的文本建议，最开始的“查看其他版本的游戏日志”还是太长了

你确定这样不会oom吗

我自己用visualvm试的时候是没注意到内存占用有什么区别，说实话多存这些record要是真能导致oom，那简直就是奇观。

下图是AddonUpdate在这个PR后的内存占用情况，（大约）59个可更新模组总共不到1mb。

为什么要把 remoteVersions 和 remoteVersions.get(0) 都存在 AddonUpdate 里面

毕竟最终更新到的版本还是那个targetVersion，这样意思表达比较直观就保留了。或者说懒得改定义也可以

3gf8jv4dv · 2026-08-28T15:08:29Z

所以有没有比较好的文本建议，最开始的“查看其他版本的游戏日志”还是太长了

“截至最新版本的所有变化” 如何？我暂时没想到其他的

ToobLac · 2026-08-29T04:21:35Z

“截至最新版本的所有变化” 如何？我暂时没想到其他的

直接“其他版本”行不行？或者“选择版本”？

要不顺便做一个让用户自己选择更新到什么版本得了，把“更新日志”那一列改成“其他版本”？

这样 targetVersion 字段也就可以省略了

ToobLac · 2026-08-29T04:24:24Z

下图是AddonUpdate在这个PR后的内存占用情况，（大约）59个可更新模组总共不到1mb。

这样就放心了。之前可能是modrinth更新会把更新日志直接拉下来然后就爆炸了，现在延后加载就好了

另外现在这么实现是不是只能看到 mr/cf 一方的版本啊？是否要把两个渠道的所有版本都显示出来，按发布时间排序？

3gf8jv4dv · 2026-08-29T04:25:06Z

直接“其他版本”行不行？或者“选择版本”？

要不顺便做一个让用户自己选择更新到什么版本得了，把“更新日志”那一列改成“其他版本”？

我觉得可以 😃

Minecraft269 · 2026-08-29T05:38:20Z

https://github.com/HMCL-dev/HMCL/actions/runs/32983901906/job/98227072480 What is this? What happened?

Minecraft269 · 2026-08-29T05:51:33Z

有俩Action炸了估计是两（三）天前的问题 https://www.githubstatus.com/ https://www.githubstatus.com/incidents/kfspvrz14xr0

Co-authored-by: mimo-v2.5

Glavo · 2026-09-03T13:17:47Z

@codex review

chatgpt-codex-connector · 2026-09-03T13:18:03Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T12:31:12.007286Z	`cc50e63`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

HMCL/HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java

Line 335 in d6fe74e

loadVersionPageUrl(object, versionPageBtn);

Refresh the version-page link when selection changes

When the user selects another target version, the listener updates targetVersionObject and reloads the changelog, but this URL loader is invoked only once during dialog construction. Consequently, the enabled mods.url hyperlink continues opening the initially selected version's page while the table and eventual update point to the newly selected version.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Glavo · 2026-09-08T12:17:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fcb77e67e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Glavo · 2026-09-09T12:27:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc50e63e7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T12:31:09Z

+                RemoteAddon.Version currentVersion = object.targetVersionObject.get();
+                if (currentVersion != null && !currentVersion.versionId().equals(version.versionId())) {
+                    // Version changed while loading, discard this result. Why's there no 'Task.interrupt()'
+                    return;


Supersede requests instead of comparing only version IDs

When the user selects A → B → A before the first A changelog request completes, both A callbacks pass this version-ID check, so the older request can finish last and overwrite the newer request’s loading/error state—for example, a late failure can hide a successfully rendered changelog behind the retry state. Fresh evidence in this revision is that the stale-result guard identifies only the selected version, not the individual request; track a request generation/task identity so only the most recently started request may update the pane.

Useful? React with 👍 / 👎.

ZZZank added 4 commits August 26, 2026 22:10

allow viewing changelog for other versions

423d350

Co-authored-by: mimo-v2.5

fix label not visible, simplify string converter

32b922e

make text a bit more clear, ensure label will not get too long

ba1f6b5

Co-authored-by: mimo-v2.5

cleanup

7731d98

github-actions Bot added the 40+ label Aug 26, 2026

fix i18n

bea4dfb

`I18N_zh_CN.properties: misspelled '其它' should be replaced by '其他'` from `gradle checkTranslations`

3gf8jv4dv reviewed Aug 26, 2026

View reviewed changes

Comment thread HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated

fix i18n (1)

1127816

"View other versions' changelog" -> "Mod Version"

c21c141

ZZZank added 4 commits August 29, 2026 14:09

"Mod Version" -> "Select version"

3d6d443

Co-authored-by: mimo-v2.5

implement "select target version"

e827fcb

update title "Changelog" -> "Select target version"

ed787be

Co-authored-by: mimo-v2.5

some unification

e2a1df0

github-actions Bot added 100+ and removed 40+ labels Aug 29, 2026

ZZZank changed the title ~~更新模组时允许查看其他版本的更新日志~~ 更新模组时允许选择目标版本并预览对应更新日志 Aug 29, 2026

fine, .getFirst() not available until Java 21

d6fe74e

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java Outdated

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java

ZZZank added 2 commits September 6, 2026 20:36

back to property, remove property.map(function) call

c5c06d3

fix remaining problems: changelog key, url, load concurrency

9fcb77e

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java Outdated

discard url not matching selected version, disable button when loading

cc50e63

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

Uh oh!

Conversation

ZZZank commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Glavo commented Aug 27, 2026

Uh oh!

3gf8jv4dv commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ToobLac commented Aug 28, 2026

Uh oh!

ToobLac commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

3gf8jv4dv commented Aug 28, 2026

Uh oh!

ZZZank commented Aug 28, 2026

Uh oh!

3gf8jv4dv commented Aug 28, 2026

Uh oh!

ToobLac commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ToobLac commented Aug 29, 2026

Uh oh!

3gf8jv4dv commented Aug 29, 2026

Uh oh!

Minecraft269 commented Aug 29, 2026

Uh oh!

Minecraft269 commented Aug 29, 2026

Uh oh!

Glavo commented Sep 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glavo commented Sep 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Glavo commented Sep 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZZZank commented Aug 26, 2026 •

edited

Loading

3gf8jv4dv commented Aug 27, 2026 •

edited

Loading

ToobLac commented Aug 28, 2026 •

edited

Loading

ToobLac commented Aug 29, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 3, 2026 •

edited

Loading