Skip to content

TSMP-PDAF Makefiles: Fixes for ensuring safe parallel compilation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjokella wants to merge 4 commits into
base: tsmp-pdaf-patched
Choose a base branch
from
Open

TSMP-PDAF Makefiles: Fixes for ensuring safe parallel compilation #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f59449
Makefile fixes
jjokella Oct 8, 2026
223934f
module ordering
jjokella Oct 8, 2026
e6ffbba
module ordering II
jjokella Oct 8, 2026
ce115d9
adding explicit dependency on mod_clm_statistics[_5].o
jjokella Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion interface/framework/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,24 @@ OBJ_USER_LOCAL = init_n_domains_pdaf.o \
# Full list of user-supplied routines for online modes
OBJ_PDAF_USER = $(OBJ_USER_GEN) $(OBJ_USER_SEIK) $(OBJ_USER_ENKF) $(OBJ_USER_LOCAL) $(OBJ_USER_PDAFOMI)

######################################################
# Module ordering dependencies (parallel build safety)
# These ensure .mod files exist before dependent translation units
# are compiled with -j.
# Level 1: parser_mpi and mod_read_obs need base modules
parser_mpi.o: mod_parallel_pdaf.o
mod_read_obs.o: mod_tsmp.o mod_parallel_pdaf.o mod_assimilation.o
# Level 2: obs handlers need mod_read_obs
obs_GRACE_pdafomi.o obs_SM_pdafomi.o: mod_read_obs.o
# Level 3: files that USE the obs handlers or parser
init_pdaf.o init_pdaf_parse.o callback_obs_pdafomi.o: \
obs_GRACE_pdafomi.o obs_SM_pdafomi.o
init_pdaf_parse.o init_parallel_pdaf.o: parser_mpi.o
# All OBJ targets need the three base modules
$(OBJ_MODEL_PDAF) $(OBJ_PDAF_INT) $(OBJ_PDAF_USER): \
mod_tsmp.o mod_parallel_pdaf.o mod_assimilation.o
# OBJ targets that also USE mod_read_obs
add_obs_error_pdaf.o init_dim_obs_f_pdaf.o init_dim_obs_l_pdaf.o init_dim_obs_pdaf.o init_obscovar_pdaf.o localize_covar_pdaf.o next_observation_pdaf.o obs_op_f_pdaf.o prodrinva_l_pdaf.o prodrinva_pdaf.o: mod_read_obs.o
######################################################

all: $(PROG)
Expand Down Expand Up @@ -168,7 +186,7 @@ libpdaf-d.a:
%.o : %.c
$(PREP_C) $(CC) $(COPT) $(CPP_DEFS) $(CFLAGS) -c $< -o $@

%.o %.mod: %.F90
%.o : %.F90
$(PREP_C) $(FC) $(OPT) $(CPP_DEFS) $(FFLAGS) -c $*.F90

.PHONY: clean depend
Expand Down
11 changes: 10 additions & 1 deletion interface/model/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,20 @@ endif

$(info $$OBJ is [${OBJ}])

## Module ordering dependencies (parallel build safety)
# Each _mod file must be compiled first so its .mod file exists when
# dependent translation units are compiled with -j.
enkf_clm_5.o print_update_clm_5.o mod_clm_statistics_5.o: enkf_clm_mod_5.o
enkf_clm_5.o: mod_clm_statistics_5.o
enkf_clm.o print_update_clm.o mod_clm_statistics.o: enkf_clm_mod.o
enkf_clm.o: mod_clm_statistics.o
enkf_cosmo.o: enkf_cosmo_mod.o

## target + rules
all: libmodel.a

libmodel.a: $(OBJ)
ar rcs $@ *.o
ar rcs $@ $(OBJ)
ranlib $@
mv $@ $(TSMPPDAFLIBDIR)
@echo "library compilation suceeded"
Expand Down
Loading