Skip to content

add top percentage filtering and return score to members #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertying wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add top percentage filtering and return score to members #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions services/registration/src/routes/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,33 @@ applicationRouter.route("/").get(

const limit = parseInt(req.query.limit as string) || 50;
const offset = parseInt(req.query.offset as string) || 0;
const applications = await ApplicationModel.accessibleBy(req.ability)
.find(filter)
.skip(offset)
.limit(limit)
.select(requireApplicationData ? "-finalScore" : "-applicationData -finalScore");
const select = requireApplicationData
? req.user?.roles.member ? "" : "-finalScore"
: "-applicationData -finalScore";

let total = matchCount;
let applications;

if (req.query.topPercentage) {
const pct = Math.min(100, Math.max(1, parseInt(req.query.topPercentage as string)));
total = Math.ceil(matchCount * (pct / 100));
applications = await ApplicationModel.accessibleBy(req.ability)
.find(filter)
.sort({ finalScore: -1 })
.skip(offset)
.limit(Math.min(limit, Math.max(0, total - offset)))
.select(select);
} else {
applications = await ApplicationModel.accessibleBy(req.ability)
.find(filter)
.skip(offset)
.limit(limit)
.select(select);
}

return res.status(200).json({
offset,
total: matchCount,
total,
count: applications.length,
applications,
});
Expand Down Expand Up @@ -156,7 +174,7 @@ applicationRouter.route("/generate-csv").get(
.find(filter)
.skip(offset)
.limit(limit)
.select(requireApplicationData ? "-finalScore" : "-applicationData -finalScore");
.select(requireApplicationData ? (req.user?.roles.member ? "" : "-finalScore") : "-applicationData -finalScore");

res.header("Content-Type", "text/csv");

Expand Down