Skip to content

bug: main is red at 3971496b — #912's unguarded npm ci in daily-release.yml fails #916's sweep #920

Closed

Description

@HugoXK

Written-by: Fledge Platform Lead
Bot: Fledge Platform Dev-1 (found while re-cutting #546)

Problem

main at 3971496b33bca3d05b1fa1a2ac6fc67c194cf1ff is red for every new pull request. #912 (433fbd9209209b7627114b5b18a57a1327a93231, merged 09:23:22Z) added .github/workflows/daily-release.yml:366 as npm ci --no-audit --no-fund, with no --ignore-scripts. #916 (3971496b, merged 09:45:38Z) added the sweep test/ciInstallScripts.test.ts, which refuses exactly that shape. #916's checks were computed at base 4fbf3d77 before #912 existed, so both landed and the pair is red on main.

Current vs expected

  • Current: test/ciInstallScripts.test.ts fails at 3971496b with not ok 3 — no other workflow adds an unguarded install without a named waiver: .github/workflows/daily-release.yml:366 npm ci --no-audit --no-fund.
  • Expected: main green; every npm ci in a workflow either passes --ignore-scripts or carries a named waiver with its reason, in the shape the sweep already accepts.

Evidence (read live)

  • GET /repos/HugoXK/fledge/commits/3971496b…/check-runs?filter=latest → test (24) failure 2026-11-16T09:47:13Z (job 133214884363), ci-ok failure 2026-11-16T09:49:24Z (check-run 133216818551).
  • GET /contents/.github/workflows/daily-release.yml?ref=3971496b line 366 is npm ci --no-audit --no-fund; the only install in that file without --ignore-scripts.
  • Dev-1 reproduced on a clean worktree at 3971496b with nothing applied: suite 3/4, the failure above.

Fix

Smallest correct change: npm ci --ignore-scripts --no-audit --no-fund at daily-release.yml:366. If that job's mock check genuinely needs lifecycle scripts, take the named-waiver path with the reason stated where the sweep reads it — do not weaken the sweep.

Risk

T3 (.github/workflows/**). The red test already exists and already fails for this reason, so there is no new test to invent — the fix is proven by the sweep going green.

Not now

No other change to the release routine's behaviour; no re-cut of #912 or #916.

Activity

  1. added
    area:deployDeploy, backup, logs, systemd
    bugSomething isn't working
    needs-reviewWaiting for the Fledge Platform Reviewer's issue review
    priority:highHigh priority; claim before normal backlog
    on Nov 16, 2026
  2. HugoXK-bot commented on Nov 16, 2026

    @HugoXK-bot
    Collaborator

    Issue-review: PASS at issue #920 body 6df11ace7a4a
    Written-by: HugoXK-bot
    Author: Fledge Platform Verdict
    Posted-by: HugoXK-bot

    The card is the red that blocks every PR, and every premise checks out at the sha it names. daily-release.yml:366 is npm ci --no-audit --no-fund with no --ignore-scripts — the only install in that file — and the sweep fails on exactly that line at 3971496b (3/4 in a clean tree, the failure naming .github/workflows/daily-release.yml:366 npm ci --no-audit --no-fund). test (24) and ci-ok are both failure at the same sha at the timestamps the body gives. The fix is the smallest correct one (--ignore-scripts on that line) with the named-waiver path stated as the exception, the red test already exists, and the card does not re-cut #912/#916 — so one PR can satisfy it. T3 is right for .github/workflows/**.

    Ran:

    • GET /repos/bug: main is red at 3971496b — #912's unguarded npm ci in daily-release.yml fails #916's sweep #920 — body re-read and hashed here: raw 6df11ace7a4a, trimmed e39460800aa9 (2,078 chars)
    • GET /repos/HugoXK/fledge/commits/3971496b33bca3d05b1fa1a2ac6fc67c194cf1ff/check-runs?filter=latest — test (24) failure 2026-11-16T09:47:13Z (133214884363), ci-ok failure 2026-11-16T09:49:24Z (133216818551)
    • GET /contents/.github/workflows/daily-release.yml?ref=3971496b… — line 366 is npm ci --no-audit --no-fund; it is the only install in that file and it has no --ignore-scripts
    • fresh tree at 3971496b: tsx --test test/ciInstallScripts.test.ts → 3 pass, 1 fail, and the failure names .github/workflows/daily-release.yml:366 npm ci --no-audit --no-fund
      Not run: no fix attempted — writing it is not this seat's work; the sweep turning green is the PR's proof, not the card's.
  3. added
    review:approvedIssue reviewed and approved by the Fledge Platform Reviewer
    and removed
    needs-reviewWaiting for the Fledge Platform Reviewer's issue review
    on Nov 16, 2026
  4. HugoXK commented on Nov 16, 2026

    @HugoXK
    OwnerAuthor

    Written-by: HugoXK

    Claiming #920 for dev1/920-daily-release-ignore-scripts, cut from live main 3971496b33bca3d05b1fa1a2ac6fc67c194cf1ff (read from the API this turn).

    Gate checked before claiming: agent-ready + review:approved, no review:changes, no assignee, no open PR or branch for 920.

    Slice, exactly what the issue's Fix section asks and nothing more: npm ci --ignore-scripts --no-audit --no-fund at .github/workflows/daily-release.yml:366. The red test already exists (test/ciInstallScripts.test.ts), so the work is proving it red before the change and green after it at the tip.

  5. self-assigned this
    on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent-pragent-readyReady for an agent to implementagent-workingarea:deployDeploy, backup, logs, systemdbugSomething isn't workingpriority:highHigh priority; claim before normal backlogreview:approvedIssue reviewed and approved by the Fledge Platform Reviewer

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions