Skip to content

feat(ui): name the workspace, not the FlyBot instance, on normal-user pages (#228) - #974

Open
HugoXK wants to merge 3 commits into
mainfrom
dev2/228-plain-language
Open

HugoXK wants to merge 3 commits into
mainfrom
dev2/228-plain-language

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Written-by: Fledge Platform Dev-2

Fixes #228

The normal-user pages (/dashboard, /console, /repos/:id, /settings) now name the workspace, not the machinery: the inbox heading, the next-run sentence, the status line, banners, the repository chip, the eyebrow and heading, the usage line and the gateway-token note. The start, stop and reinitialize controls are named for the workspace and each carries a one-line hint. The footer brand line and the stageMode form values are unchanged.

Tip: 4191645a26c6c8386e4955df7b2c41fe4a7ab77c, tree 81fbebb9ace8dd483a9c3ccd2d7b8ccd4a2f820f, parent 36d9c8c00a3b1722ea0165adea3f0eac89840caf, base 4cfe2986f6df01ac77af0eee54eddd67820d8cf8. 9 files, +243/−43, three commits.

Two follow-up commits clear gate findings on this branch, both test-only: 36d9c8c0, then 4191645a (pushed through the Git Data API because github.com:443 timed out). They make the sweep's script/style end-tag patterns accept any end-tag body (</script >, </script\t\n bar>), which is what CodeQL's bad-tag-filter query requires. npm run check was re-run at this tip — 2613/2613, exit 0. Checks at 4191645a: ci-ok success, CodeQL success, codeql-required success, pr-lint success; review-gate awaits the PASS.

Ran:

  • npm run check — pass, 2613/2613, exit 0 (lint + typecheck + tests + build)
  • final test/plainLanguage.test.ts at base 4cfe2986 — 1 pass / 4 fail for the copy (the one pass is the guard: footer brand and value="enforced|shadow|off" survive)
  • node scripts/version.mjs check — 0.4.0 ok; node scripts/changelog.mjs check — 47 fragments ok

Not run: Docker image, real SMTP.

Risk: T2 (src/views/) — risk-tier: T2; basis: src/views/checklist.ts (2 views T2, 6 tests T1, 1 fragment T0).

Scope: exactly the card's 27 strings — 26 in pages.ts, 1 in checklist.ts — plus the one-line hint on start/stop/reinitialize at both call sites. What stays is exactly the 12 exemptions (teamPage buttons, audit map, admin, sibling products, agentWorkspace, admin count row) and the layout.ts:308 footer, untouched. Five old-copy assertions updated in test/pages, test/nextAction, test/setupChecklist, test/limits, test/team.

Deliberately not widened: src/lib/failure.ts:259 INSTANCE_NOT_READY banner still says "The FlyBot instance is not ready…" and renders on /repos/:id after a refusal; it is outside the card's enumerated 27, and src/jobs/service.ts:3446 digest wording is email-only. Both can be folded in on this branch if the reviewer asks.

Rollback: revert the squash commit; no data or route change.

Docs-not-needed: copy-only — routes, contracts and architecture unchanged.

Changelog: changelog.d/228-plain-language.changed.md.

Comment thread test/plainLanguage.test.ts Fixed
Comment thread test/plainLanguage.test.ts Fixed
Replace the machinery name with the product term on /dashboard, /console,
/repos/:id and /settings: status lines, banners, the inbox heading, the next-run
sentence, the usage line, the repository chip, the eyebrow and the heading.
Rename the start, stop and reinitialize controls for the workspace and give each
one a one-line hint. The footer brand line and the stageMode form values stay.

Fixes #228
Docs-not-needed: copy-only change in src/views; routes, contracts and the architecture are unchanged.
Written-by: Fledge Platform Dev-2
CodeQL's bad-tag-filter query flags `</script>` for missing `</script >`, so the
sweep allows whitespace before `>` on the script and style end tags.

Fixes #228
Docs-not-needed: test-only regex; no product copy, route or doc changes.
Written-by: Fledge Platform Dev-2
The CodeQL annotation names `</script\t\n bar>` as an end tag a `\s*` pattern
misses, so the sweep now accepts any text up to `>` on the script and style end
tags, which is what the HTML tokenizer does.

Fixes #228
Docs-not-needed: test-only regex; no product copy, route or doc changes.
Written-by: Fledge Platform Dev-2

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: replace internal agent jargon with plain user-facing language

2 participants