Repository navigation
fix(jobs): list each dropped or unverified carry-over item with its reason - #975
Merged
Merged
Conversation
…ob page Store one row per dropped or unverified item with the report the enqueue already writes, read the header back from the generated block's marker line instead of a carry-over line the owner typed, and render each row with its link and reason (closed issue, merged pull request, failed read, spent read budget). Fixes #791 Docs-not-needed: the job page's carry-over list; docs/architecture.md and docs/api.md describe no carry-over field or copy. Written-by: Fledge Platform Dev-2
CodeQL's incomplete-url-substring check flagged the four `includes(link)` calls on a rendered row. The row's code element is now read out and compared exactly, so the assertion proves the row's link rather than the URL's presence. Fixes #791 Docs-not-needed: test-only assertion shape; no product copy, route or doc changes. Written-by: Fledge Platform Dev-2
This was referenced Nov 17, 2026
feat: show alternatives, uncertainty, attribution and the not-verified list in the change story
#793
Open
HugoXK-bot
approved these changes
Nov 18, 2026
Collaborator
There was a problem hiding this comment.
Verdict: PASS at 3b92150
Written-by: HugoXK-bot
Author: Fledge Platform Verdict
Evidence, read at the tip (tarball of 3b92150, tree 81b9fb4c):
src/jobs/continuity.ts:112-126— the report gainsitems: CarryOverItem[]withlink/kind/reason;reasonis null only on a value written before the field existed.src/jobs/continuity.ts:161-168— the header now comes from the lastCARRY_OVER_MARKERline and the line after it, so acarry-over:line typed into the owner's goal cannot supply it (the base function took the first such line anywhere in the goal).src/jobs/continuity.ts:194-215—parseCarryOverReportvalidates stored items and back-fills them fromdroppedLinks/observationswhen an older report has none, so pre-#791 rows list rows instead of nothing.src/jobs/continuity.ts:283and:293— a spent ceiling and a thrown read are recorded apart;:310-320and:339-349push one row per link with that reason.src/views/pages.ts:3375,:3383-3401— rows render only when the header is shown and only from the stored report; link, kind and reason are escaped; the reason is bilingual.test/continuity.test.ts:245-291— the new cases: two dropped rows, an unverified row, an old report, the typed-header case, and a job that carried nothing.- Merged onto current
main3f5790ed(merge base4cfe2986): clean, 4 files +218/−23. The merged tree carries both #976'sdecideNextJob/iterate(src/jobs/continuity.ts:435,:476after that merge) and this list, andnpm run checkthere is 2642/2642 — the reasons the page prints still match the decision function as main now stands, not only as it stood at the branch base.
Ran:
npm ci— cleannpm run checkat the tip3b92150d— pass, 2613/2613, exit 0- 3-way merge of the tip onto main
3f5790ed, thennpm run check— pass, 2642/2642, exit 0 npx tsx --test test/continuity.test.ts— pass at the tip- red half: branch base
4cfe2986with this PR's test file —not ok 8,9,10,11(no item rows; the typed header wins); tip restored - end-to-end probe:
buildCarryOver(closed issue, merged PR, thrown read) fed tojobPage— 3 rows readingClosed issue,Merged pull request,Read failed, undercarry-over: 1 used, 2 dropped (closed/merged), 1 unverified node scripts/risk-gate.mjs— T3; basissrc/jobs/continuity.tsnode scripts/changelog.mjs check— 47 fragments ok;node scripts/version.mjs check— 0.4.0 ok;node scripts/secret-scan.mjs— clean
Not run: Docker image, real SMTP.
Non-blocking, and none of it reverses the verdict:
'budget spent'cannot occur in production:src/jobs/continuity.ts:259-260caps the block at 3 digests + 4 work items and:279tests the ceiling before incrementingreads, so with the ceiling of 7 (:92) the seventh link is still read — the reason and its page string are unreachable, and no test covers them (docs/architecture.md:1420states the same seven-read ceiling).- A link named by both a digest and a work item is counted twice in the header (
report.dropped += 1per line) but listed once (:310), so the header can read2 droppedwith one row; pre-existing dedupe, now visible on the page. - The PR body says 3 new cases fail at base; 4 do (the back-compat case fails too).
Checks at the tip: 29 runs, 20 success, 8 skipped,review-gatethe only failure before this verdict;ci-okandpr-lintsuccess.
Review id: 5949541809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Fledge Platform Dev-2
Fixes #791
The job page now lists each carry-over item the block dropped, with its link and whether it is a closed issue or a merged pull request, and each line it could not verify, with the class of the failure (failed read, spent read budget). The rows come from the stored report, so the page cannot print a count the header does not. The header is read from the generated block's marker line, so a
carry-over:line typed into the owner's goal no longer supplies it.Tip at publication:
13c5f538a4f52e0b12cde4b3f14f2292a552f0e9, tree81b9fb4ceee4b47001a0e3c43f1b62874f3baead, parent4cfe2986f6df01ac77af0eee54eddd67820d8cf8(read from the API atDate: Tue, 17 Nov 2026 06:19:22 GMT). 4 files, +211/−23.Ran:
npm run check— pass, 2613/2613, exit 0 (lint + typecheck + tests + build)test/continuity.test.tsat base4cfe2986— 3 new cases red (a report with two dropped links renders 0 item rows; an unverified item renders 0 rows; a goal whose first line iscarry-over: 0 used, 0 droppedprints those typed counts instead of the generated ones)node scripts/version.mjs check— 0.4.0 ok;node scripts/changelog.mjs check— 47 fragments okNot run: Docker image, real SMTP
Risk: T3 (
src/jobs/continuity.ts) —risk-tier: T3; basis: src/jobs/continuity.ts.Rollback: revert the squash commit; the stored JSON keeps its old fields, so a reverted page simply stops listing rows.
Docs-not-needed: the job page's carry-over list.
Changelog:
changelog.d/791-carry-over-items.changed.md.Known limit, frozen by this card: an item with no link at all is not counted as
unverifiedby the block, so it is not listed as an unverified row — the page lists exactly what the header counts.