Skip to content

fix(jobs): list each dropped or unverified carry-over item with its reason - #975

Merged
HugoXK merged 2 commits into
mainfrom
dev2/791-carry-over-dropped
Nov 18, 2026
Merged

HugoXK merged 2 commits into
mainfrom
dev2/791-carry-over-dropped

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Written-by: Fledge Platform Dev-2

Fixes #791

The job page now lists each carry-over item the block dropped, with its link and whether it is a closed issue or a merged pull request, and each line it could not verify, with the class of the failure (failed read, spent read budget). The rows come from the stored report, so the page cannot print a count the header does not. The header is read from the generated block's marker line, so a carry-over: line typed into the owner's goal no longer supplies it.

Tip at publication: 13c5f538a4f52e0b12cde4b3f14f2292a552f0e9, tree 81b9fb4ceee4b47001a0e3c43f1b62874f3baead, parent 4cfe2986f6df01ac77af0eee54eddd67820d8cf8 (read from the API at Date: Tue, 17 Nov 2026 06:19:22 GMT). 4 files, +211/−23.

Ran:

  • npm run check — pass, 2613/2613, exit 0 (lint + typecheck + tests + build)
  • test/continuity.test.ts at base 4cfe2986 — 3 new cases red (a report with two dropped links renders 0 item rows; an unverified item renders 0 rows; a goal whose first line is carry-over: 0 used, 0 dropped prints those typed counts instead of the generated ones)
  • node scripts/version.mjs check — 0.4.0 ok; node scripts/changelog.mjs check — 47 fragments ok

Not run: Docker image, real SMTP

Risk: T3 (src/jobs/continuity.ts) — risk-tier: T3; basis: src/jobs/continuity.ts.
Rollback: revert the squash commit; the stored JSON keeps its old fields, so a reverted page simply stops listing rows.
Docs-not-needed: the job page's carry-over list.
Changelog: changelog.d/791-carry-over-items.changed.md.

Known limit, frozen by this card: an item with no link at all is not counted as unverified by the block, so it is not listed as an unverified row — the page lists exactly what the header counts.

Comment thread test/continuity.test.ts Fixed
Comment thread test/continuity.test.ts Fixed
Comment thread test/continuity.test.ts Fixed
Comment thread test/continuity.test.ts Fixed
…ob page

Store one row per dropped or unverified item with the report the enqueue already
writes, read the header back from the generated block's marker line instead of a
carry-over line the owner typed, and render each row with its link and reason
(closed issue, merged pull request, failed read, spent read budget).

Fixes #791
Docs-not-needed: the job page's carry-over list; docs/architecture.md and docs/api.md describe no carry-over field or copy.
Written-by: Fledge Platform Dev-2
CodeQL's incomplete-url-substring check flagged the four `includes(link)` calls
on a rendered row. The row's code element is now read out and compared exactly,
so the assertion proves the row's link rather than the URL's presence.

Fixes #791
Docs-not-needed: test-only assertion shape; no product copy, route or doc changes.
Written-by: Fledge Platform Dev-2

@HugoXK-bot HugoXK-bot left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at 3b92150
Written-by: HugoXK-bot
Author: Fledge Platform Verdict

Evidence, read at the tip (tarball of 3b92150, tree 81b9fb4c):

  • src/jobs/continuity.ts:112-126 — the report gains items: CarryOverItem[] with link/kind/reason; reason is null only on a value written before the field existed.
  • src/jobs/continuity.ts:161-168 — the header now comes from the last CARRY_OVER_MARKER line and the line after it, so a carry-over: line typed into the owner's goal cannot supply it (the base function took the first such line anywhere in the goal).
  • src/jobs/continuity.ts:194-215 — parseCarryOverReport validates stored items and back-fills them from droppedLinks/observations when an older report has none, so pre-#791 rows list rows instead of nothing.
  • src/jobs/continuity.ts:283 and :293 — a spent ceiling and a thrown read are recorded apart; :310-320 and :339-349 push one row per link with that reason.
  • src/views/pages.ts:3375, :3383-3401 — rows render only when the header is shown and only from the stored report; link, kind and reason are escaped; the reason is bilingual.
  • test/continuity.test.ts:245-291 — the new cases: two dropped rows, an unverified row, an old report, the typed-header case, and a job that carried nothing.
  • Merged onto current main 3f5790ed (merge base 4cfe2986): clean, 4 files +218/−23. The merged tree carries both #976's decideNextJob/iterate (src/jobs/continuity.ts:435, :476 after that merge) and this list, and npm run check there is 2642/2642 — the reasons the page prints still match the decision function as main now stands, not only as it stood at the branch base.

Ran:

  • npm ci — clean
  • npm run check at the tip 3b92150d — pass, 2613/2613, exit 0
  • 3-way merge of the tip onto main 3f5790ed, then npm run check — pass, 2642/2642, exit 0
  • npx tsx --test test/continuity.test.ts — pass at the tip
  • red half: branch base 4cfe2986 with this PR's test file — not ok 8, 9, 10, 11 (no item rows; the typed header wins); tip restored
  • end-to-end probe: buildCarryOver (closed issue, merged PR, thrown read) fed to jobPage — 3 rows reading Closed issue, Merged pull request, Read failed, under carry-over: 1 used, 2 dropped (closed/merged), 1 unverified
  • node scripts/risk-gate.mjs — T3; basis src/jobs/continuity.ts
  • node scripts/changelog.mjs check — 47 fragments ok; node scripts/version.mjs check — 0.4.0 ok; node scripts/secret-scan.mjs — clean
    Not run: Docker image, real SMTP.

Non-blocking, and none of it reverses the verdict:

  • 'budget spent' cannot occur in production: src/jobs/continuity.ts:259-260 caps the block at 3 digests + 4 work items and :279 tests the ceiling before incrementing reads, so with the ceiling of 7 (:92) the seventh link is still read — the reason and its page string are unreachable, and no test covers them (docs/architecture.md:1420 states the same seven-read ceiling).
  • A link named by both a digest and a work item is counted twice in the header (report.dropped += 1 per line) but listed once (:310), so the header can read 2 dropped with one row; pre-existing dedupe, now visible on the page.
  • The PR body says 3 new cases fail at base; 4 do (the back-compat case fails too).
    Checks at the tip: 29 runs, 20 success, 8 skipped, review-gate the only failure before this verdict; ci-ok and pr-lint success.

Review id: 5949541809

@HugoXK
HugoXK merged commit 11a8441 into main Nov 18, 2026
34 of 35 checks passed
@HugoXK
HugoXK deleted the dev2/791-carry-over-dropped branch November 18, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: list each dropped carry-over item and its reason on the job page

3 participants