Skip to content

fix(release): retire the unreachable tag action from the release drive - #979

Merged
HugoXK merged 1 commit into
mainfrom
dev1/866-release-drive-tag-action
Nov 18, 2026
Merged

HugoXK merged 1 commit into
mainfrom
dev1/866-release-drive-tag-action

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Written-by: Fledge Platform Dev-1

Fixes #866

release-drive.mjs can return a tag action that nothing can ever execute: the drive is only invoked from the release job while the tag is written by the tag job on a merged release PR. An action that cannot run is worse than none — it reads as a missing reconcile in every audit. This retires the tag action from scripts/lib/release-drive.mjs and its types, drops the now-dead mergedPrs: [] input from daily-release.yml, and corrects the docs/deploy.md paragraph that claimed the drive still reports tag.

Scope note: #906 (8213cec) already shipped the reconcile half (AC1–AC3) on main. AC4 is a ruleset bypass, which is an owner action, so this slice takes the issue's other allowed option — remove the dead action and leave the tag job as the only tag writer.

Tip at publication: c15b10ba3a778154b4e580bd571d55a6f5d5856b, tree 313392db021f04f766a7b32a195875535d4eacc4, parent c3d16bbc51bc04e0fc405f1f4e6c0e7bc1868439. 7 files, +35/−151.

Ran:

  • red at base c3d16bbc — the replacement test fails with 'tag' !== 'none' (1 fail / 24)
  • npm run check at the tip — exit 0, 2605/2605
  • node scripts/risk-gate.mjs --base c3d16bb — T3, basis .github/workflows/daily-release.yml

Not run: Docker image, a real release dispatch.

Risk: T3 (.github/workflows/**, scripts/**, docs/deploy.md).
Rollback: revert the squash commit; the drive reports an action it cannot execute again, the workflow regains its unused input and the doc its old paragraph. No release state is migrated.
Docs: docs/deploy.md corrected in this PR.
Changelog: changelog.d/866-retire-drive-tag-action.changed.md.

@HugoXK-bot HugoXK-bot left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at c15b10b
Written-by: HugoXK-bot
Author: Fledge Platform Verdict

Evidence, read at the tip (tarball of c15b10b, tree 313392db):

  • scripts/lib/release-drive.mjs:18-21 — the module now says there is deliberately no tag action and names the tag job as the only tag writer (#866).
  • scripts/lib/release-drive.mjs:69-70 — decide() no longer reads mergedPrs/tags; the single return { action: 'tag' } the base module had (scripts/lib/release-drive.mjs:138 at c3d16bbc) is gone.
  • .github/workflows/daily-release.yml:256 — the drive state no longer passes mergedPrs; at base c3d16bbc that key was the literal [] (.github/workflows/daily-release.yml:256 there), so the retired branch could not return tag in production — it was unreachable, not merely unused.
  • .github/workflows/daily-release.yml:553-561 — the tag job still runs on push and schedule; it resolves the merged release: v<version> PR itself (resolveTarget, .github/workflows/daily-release.yml:595-612) and still creates the tag and dispatches the publish run, so nothing it needed was removed.
  • .github/workflows/daily-release.yml:270 — no release-job step consumes the drive's tag/sha; steps.decide.outputs.tag is read only by the tag job's own decide step (.github/workflows/daily-release.yml:686, :706).
  • scripts/lib/release-drive.d.mts:40 — DriveDecision.action drops tag, and the DriveMergedPr/sha/tag fields are removed; the tip typechecks.
  • test/mechanicalRelease.test.ts:220-232 — new guard: a caller that still supplies the merged list gets none, never tag.
  • test/releaseState.test.ts:379-383 — the merged-PR case now expects open-pr; the five tests that exercised the removed branch are gone with it.
  • docs/deploy.md:576-581 and changelog.d/866-retire-drive-tag-action.changed.md:1 match the code: the drive carries no tag action, a merged release PR without a tag is the tag job's repair.

Ran:

  • npm ci — clean
  • npm run check — pass, 2605/2605 tests, exit 0
  • npx tsx --test test/mechanicalRelease.test.ts test/releaseState.test.ts test/releaseCiOk.test.ts test/dailyRelease.test.ts — 73/73 pass
  • red half: base c3d16bbc's scripts/lib/release-drive.mjs and .d.mts dropped into the tip tree — not ok 18, expected none, actual tag; tip files restored, tree clean
  • node scripts/risk-gate.mjs --base c3d16bbc — T3; basis .github/workflows/daily-release.yml
  • node scripts/changelog.mjs check — 48 fragments ok; node scripts/version.mjs check — 0.4.0 ok; node scripts/secret-scan.mjs — clean
    Not run: Docker image, a real release dispatch (needs Actions and a release PR).

Non-blocking: .github/workflows/daily-release.yml:270 still writes tag=${decision.tag ?? ""} into GITHUB_OUTPUT, a field the drive no longer has; no release-job step reads it, so it only emits an empty tag= line. Checks at the tip: 29 runs, 21 success, 7 skipped, review-gate the only failure (no verdict at this tip before this one); ci-ok and pr-lint success.

Review id: 5949320894

@HugoXK
HugoXK merged commit 3f5790e into main Nov 18, 2026
34 of 35 checks passed
@HugoXK
HugoXK deleted the dev1/866-release-drive-tag-action branch November 18, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: a failed tag dispatch has no reconcile, and the release drive tag action is never executed

2 participants