Repository navigation
fix(release): retire the unreachable tag action from the release drive - #979
Merged
Merged
Conversation
HugoXK-bot
approved these changes
Nov 18, 2026
Collaborator
There was a problem hiding this comment.
Verdict: PASS at c15b10b
Written-by: HugoXK-bot
Author: Fledge Platform Verdict
Evidence, read at the tip (tarball of c15b10b, tree 313392db):
scripts/lib/release-drive.mjs:18-21— the module now says there is deliberately notagaction and names the tag job as the only tag writer (#866).scripts/lib/release-drive.mjs:69-70—decide()no longer readsmergedPrs/tags; the singlereturn { action: 'tag' }the base module had (scripts/lib/release-drive.mjs:138atc3d16bbc) is gone..github/workflows/daily-release.yml:256— the drive state no longer passesmergedPrs; at basec3d16bbcthat key was the literal[](.github/workflows/daily-release.yml:256there), so the retired branch could not returntagin production — it was unreachable, not merely unused..github/workflows/daily-release.yml:553-561— thetagjob still runs onpushandschedule; it resolves the mergedrelease: v<version>PR itself (resolveTarget,.github/workflows/daily-release.yml:595-612) and still creates the tag and dispatches the publish run, so nothing it needed was removed..github/workflows/daily-release.yml:270— no release-job step consumes the drive'stag/sha;steps.decide.outputs.tagis read only by the tag job's own decide step (.github/workflows/daily-release.yml:686,:706).scripts/lib/release-drive.d.mts:40—DriveDecision.actiondropstag, and theDriveMergedPr/sha/tagfields are removed; the tip typechecks.test/mechanicalRelease.test.ts:220-232— new guard: a caller that still supplies the merged list getsnone, nevertag.test/releaseState.test.ts:379-383— the merged-PR case now expectsopen-pr; the five tests that exercised the removed branch are gone with it.docs/deploy.md:576-581andchangelog.d/866-retire-drive-tag-action.changed.md:1match the code: the drive carries notagaction, a merged release PR without a tag is the tag job's repair.
Ran:
npm ci— cleannpm run check— pass, 2605/2605 tests, exit 0npx tsx --test test/mechanicalRelease.test.ts test/releaseState.test.ts test/releaseCiOk.test.ts test/dailyRelease.test.ts— 73/73 pass- red half: base
c3d16bbc'sscripts/lib/release-drive.mjsand.d.mtsdropped into the tip tree —not ok 18, expectednone, actualtag; tip files restored, tree clean node scripts/risk-gate.mjs --base c3d16bbc— T3; basis.github/workflows/daily-release.ymlnode scripts/changelog.mjs check— 48 fragments ok;node scripts/version.mjs check— 0.4.0 ok;node scripts/secret-scan.mjs— clean
Not run: Docker image, a real release dispatch (needs Actions and a release PR).
Non-blocking: .github/workflows/daily-release.yml:270 still writes tag=${decision.tag ?? ""} into GITHUB_OUTPUT, a field the drive no longer has; no release-job step reads it, so it only emits an empty tag= line. Checks at the tip: 29 runs, 21 success, 7 skipped, review-gate the only failure (no verdict at this tip before this one); ci-ok and pr-lint success.
Review id: 5949320894
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Fledge Platform Dev-1
Fixes #866
release-drive.mjscan return atagaction that nothing can ever execute: the drive is only invoked from thereleasejob while the tag is written by thetagjob on a merged release PR. An action that cannot run is worse than none — it reads as a missing reconcile in every audit. This retires thetagaction fromscripts/lib/release-drive.mjsand its types, drops the now-deadmergedPrs: []input fromdaily-release.yml, and corrects thedocs/deploy.mdparagraph that claimed the drive still reportstag.Scope note:
#906(8213cec) already shipped the reconcile half (AC1–AC3) onmain. AC4 is a ruleset bypass, which is an owner action, so this slice takes the issue's other allowed option — remove the dead action and leave thetagjob as the only tag writer.Tip at publication:
c15b10ba3a778154b4e580bd571d55a6f5d5856b, tree313392db021f04f766a7b32a195875535d4eacc4, parentc3d16bbc51bc04e0fc405f1f4e6c0e7bc1868439. 7 files, +35/−151.Ran:
c3d16bbc— the replacement test fails with'tag' !== 'none'(1 fail / 24)npm run checkat the tip — exit 0, 2605/2605node scripts/risk-gate.mjs --base c3d16bb— T3, basis.github/workflows/daily-release.ymlNot run: Docker image, a real release dispatch.
Risk: T3 (
.github/workflows/**,scripts/**,docs/deploy.md).Rollback: revert the squash commit; the drive reports an action it cannot execute again, the workflow regains its unused input and the doc its old paragraph. No release state is migrated.
Docs:
docs/deploy.mdcorrected in this PR.Changelog:
changelog.d/866-retire-drive-tag-action.changed.md.