refactor: Remove xml2js - #429
Merged
Merged
Conversation
abmusse
requested changes
Sep 22, 2026
abmusse
left a comment
abmusse
left a comment
Member
There was a problem hiding this comment.
Now that #401 was merged I actually think we need fast-xml-parser as normal dependecy since we rely on it in
nodejs-itoolkit/lib/Deprecated.js
Line 8 in caff23b
Once we drop these deperacted methods it shouldn't be needed in as a normal dependecy move it to dev dependency. I see its currently liisted as optional:
Line 62 in caff23b
we should move it to standard dependency for now.
Member
Author
|
Ahh, yeah good catch. |
Member
Author
|
And looks like depd is only needed for the deprecated functions too. I saw that and was wondering. Too bad we can't put comments in JSON... |
kadler
force-pushed
the
remove-xml2js
branch
from
September 22, 2026 03:48
eb46c20 to
b2c6463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer used for anything anymore so remove it. fast-xml-parser needs to be added as a dev dependency now that it's used for tests (since #401).
Fixes #350