Skip to content

48472: Fix fatal error with celtic/lti 5.4.4 and later #12185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saaweel merged 1 commit into from
Oct 8, 2026
+10 −4
Merged

48472: Fix fatal error with celtic/lti 5.4.4 and later #12185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ILIAS/LTIProvider/classes/InternalProvider/class.ilAuthProviderLTI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public function doAuthentication(\ilAuthStatus $status): bool
$lti_provider->kid = $pk['kid'];
$lti_provider->signatureMethod = 'RS256';

$lti_provider->handleRequest();
$lti_provider->processRequest();
$this->provider = $lti_provider;
$this->messageParameters = $this->provider->getMessageParameters();

Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/LTIProvider/classes/InternalProvider/class.ilLTIExitException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* The library is designed to be the only thing handling an LTI request, so it ends the request
* itself once the message has been processed. ILIAS still has to authenticate the user and send
* them to the requested object afterwards, so it asks the library to throw this exception rather
* than to exit, and regains control in ilLTITool::handleRequest().
* than to exit, and regains control in ilLTITool::processRequest().
*/
class ilLTIExitException extends ilException
{
Expand Down
10 changes: 8 additions & 2 deletions components/ILIAS/LTIProvider/classes/InternalProvider/class.ilLTITool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ public function parsePostBody(ArrayBasedRequestWrapper $postData): array
return $res;
}

public function handleRequest(bool $strictMode = null, bool $disableCookieCheck = false, bool $generateWarnings = false): void
/**
* Process the LTI request and return to ILIAS once the message has been accepted.
*
* This does not override handleRequest(): the library declares that method as never returning,
* while ILIAS needs control back to authenticate the user.
*/
public function processRequest(): void
{
global $DIC;

Expand All @@ -107,7 +113,7 @@ public function handleRequest(bool $strictMode = null, bool $disableCookieCheck
$this->onExitExceptionClass = ilLTIExitException::class;

try {
parent::handleRequest($strictMode, $disableCookieCheck, $generateWarnings);
$this->handleRequest();
} catch (ilLTIExitException $e) {
$this->sendPendingResponse();
}
Expand Down
Loading