Skip to content

216 bug swe l3 temperatures unit inconsistency and unit labeling - #218

Merged
jtniehof merged 2 commits into
IMAP-Science-Operations-Center:mainfrom
leowerneck:216-bug---swe-l3-temperatures---unit-inconsistency-and-unit-labeling
Sep 30, 2026
Merged

jtniehof merged 2 commits into
IMAP-Science-Operations-Center:mainfrom
leowerneck:216-bug---swe-l3-temperatures---unit-inconsistency-and-unit-labeling

Conversation

@leowerneck

@leowerneck leowerneck commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Change Summary

Closes #216.

Overview

This PR adds the following missing UNITS labels to fix SWE L3 CDFs:

  • total_speed_integrated: km/s
  • core_t_parallel_integrated: K
  • halo_t_parallel_integrated: K
  • total_t_parallel_integrated: K

It also reformats the tests/cdf/test_yaml_var_metadata.py using ruff format. Because of this, it is recommended to review the first commit, then the second commit.

@leowerneck leowerneck self-assigned this Sep 29, 2026
@leowerneck
leowerneck requested a review from jtniehof September 29, 2026 21:22
@leowerneck leowerneck added bug Something isn't working Ins: SWE Related to the SWE instrument labels Sep 29, 2026
@leowerneck leowerneck added this to IMAP Sep 29, 2026
@leowerneck leowerneck added the Data Release 2 Deadline: September 1, 2026 label Sep 29, 2026

@jtniehof jtniehof left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Annoyingly, we'll have to reprocess just for this to make sure it gets into R2.

(I did start the container build and push to dev)

@jtniehof
jtniehof merged commit 22c9638 into IMAP-Science-Operations-Center:main Sep 30, 2026
16 of 17 checks passed
@leowerneck
leowerneck deleted the 216-bug---swe-l3-temperatures---unit-inconsistency-and-unit-labeling branch September 30, 2026 15:49
@leowerneck

Copy link
Copy Markdown
Collaborator Author

I'll change the issue to "Validating" and kick in the reprocessing once the containers are deployed.

@jtniehof

Copy link
Copy Markdown
Collaborator

Container is on dev; are you able to promote to prod or should I poke someone else?

@leowerneck

Copy link
Copy Markdown
Collaborator Author

I just promoted the SWE L3 container to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Data Release 2 Deadline: September 1, 2026 Ins: SWE Related to the SWE instrument

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

BUG - SWE L3 Temperatures - Unit Inconsistency and Unit Labeling

2 participants