A new IMAP_LO_INSTR frame - #3508
Open
vineetbansal wants to merge 8 commits into
Open
vineetbansal wants to merge 8 commits into
vineetbansal wants to merge 8 commits into
Conversation
…ure; switch tests to imap_140.tf
vineetbansal
marked this pull request as draft
September 28, 2026 22:16
…ns expected boresight
tmplummer
reviewed
Sep 29, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
Overall, this looks really good! Nice work on this.
vineetbansal
changed the title
…itude for a time interval
vineetbansal
force-pushed
the
vb/issue3494
branch
from
September 29, 2026 20:10
62fc9b6 to
366df2e
Compare
… now testing IMAP_LO_INSTR as well as IMAP_LO_STAR_SENSOR
vineetbansal
marked this pull request as ready for review
September 29, 2026 20:25
tmplummer
reviewed
Oct 1, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
I think you raised a good point about the unused functions:
haven't taken out the now-unused (except for tests)
get_lo_pivot_boresightandlo_instrument_pointingfunctions. I didn't see a pattern ofwarnings.warnorraise DeprecationWarninganywhere else so I've left them in. Let me know if these should be taken out in this PR or we can leave that for the future.
I'd say that you should go ahead and remove them.
Collaborator
Author
|
PR #3518 is using these functions, so once that is merged, I'll remove these and update their references accordingly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3494.
I'm making some assumptions about the
imap_140.tfthat will be available upstream soon. Once we have that file, I can replace the fileimap_processing/tests/spice/test_data/imap_140.tfin this PR with the official version and make any necessary tweaks to this PR.EDIT: I had totally forgotten that @tmplummer had provided me with the correct
imap_140.tffile. Updated this PR by using the official version of that file.