ULTRA L1b: replace the DE product lookup with the extendedspin priority config - #3511
Merged
lacoak21 merged 13 commits intoOct 1, 2026
Conversation
lacoak21
requested review from
bryan-harter and
leowerneck
and
a balanced review from Copilot
September 29, 2026 20:59
leowerneck
approved these changes
Oct 1, 2026
leowerneck
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I left a few optional comments, but I don't think a new review is necessary even if you choose to address them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Change Summary
closes #3498
closes #3499
Overview
Before this PR, L1b extendedspin read a de-product-lookup ancillary file whose only job was to say which L1b DE product (raw or priority 1–4) to use for each repointing.
This PR replaces it with a new l1b-{sensor}sensor-extendedspin-config ancillary file. Each row applies from its pointing number until the next row's pointing, and holds:
This PR also updates how valid events are counted, at each energy bin, we may use a different direct event source. E.g. the last energy bin should always use the priority 0 (raw de) data, otherwise use priority 1 ( some of this logic doesnt make sense to me but its what Bob implemented so im going to ask him about this in the tagup tomorrow)
Testing
Update tests to work with new config file.