Fix bug in identifying Hi esa sweep boundaries

[tmplummer]

Change Summary

Overview

• Fix Hi goodtimes ESA sweep indexing: a new sweep now starts at any 8-spin set whose ESA step is <= the previous set's, so each ESA step appears at most once per sweep.
• Fixes repoint 152, where gain-test HV cycling cut sweeps off after their first ESA 1 set. Each cut-off set was merged into the next sweep, so the txt reported good ESA 1 data as culled.
• Closes BUG - Hi goodtimes sweep indexing merges truncated sweeps, mis-culling ESA step 1 #3519. Follow-up for Statistical Filter 0 normalization: BUG - Hi goodtimes Statistical Filter 0 normalizes sweep counts by per-Pointing ESA step count #3529.

File changes

• hi_goodtimes.py: _get_sweep_indices() now takes esa_step_met and only compares ESA steps where an 8-spin set changes. _add_sweep_indices() passes esa_step_met (DE) or met (goodtimes).
• test_hi_goodtimes.py: added esa_step_met to the test DE datasets and updated the _get_sweep_indices tests for the new signature.

Testing

• New tests for cut-off sweeps, 10-step sweeps, and multiple packets per set; all 184 goodtimes tests pass.
• Regenerated the txt files for repoints 145–155 from the 0777 goodtimes CDFs. Only repoint 152 changes, and every txt now matches its CDF cull flags.

Closes: #3519

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation matches the reported failure mode and includes focused regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Hi goodtimes sweep boundaries so truncated or repeated ESA steps begin new sweeps without splitting packets from the same 8-spin set.

Changes:

• Uses esa_step_met to identify 8-spin set transitions.
• Treats non-increasing ESA steps as sweep boundaries.
• Adds coverage for truncated, ten-step, and multi-packet sweeps.

File	Description
imap_processing/​hi/​hi_goodtimes.py	Corrects sweep boundary detection and MET selection.
imap_processing/​tests/​hi/​test_hi_goodtimes.py	Updates fixtures and expands sweep-indexing tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.