Repository navigation
Conversation
* From SPDF feedback on release 2 sample files
jtniehof
added
bug
* ASCIIbetical is hard to remember
Collaborator
Author
|
@mstarkey2158 : can you do a quick check on the proposed label? You can see one way it'll plot in the figure above (CAVA will be similar although not identical) |
Collaborator
|
@jtniehof These look fine. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
imap_codice_l2_hi-omniswitchedDISPLAY_TYPEtospectrogram, which means the variables needLABLAXIS.Overview
SPDF noted that we need
LABLAXISto display as a spectrogram. This is normally used to label the colorbar, e.g.:The existing
LABL_AXIS_1remains so a stackplot is still possible, just not the default.File changes
cdf/config/imap_codeice_l2-hi-omni_variable_attrs.yaml: addLABLAXISto intensity ("SPECIES Diff. Int.") and uncertainty ("SPECIES uncertainty") variables.Testing
Similar attributes don't seem to be tested in current unit tests, so added no testing. Did check the output of running with the new code (figure above).