Repository navigation
Cleared command flags from pyro test -> safe after timeout - #226
Merged
Merged
Conversation
|
FSM SILSIM: 6/6 passed ✓ — plots |
EDED2314
approved these changes
Oct 23, 2026
EDED2314
left a comment
EDED2314
left a comment
There was a problem hiding this comment.
@mpkarpov-ui Let us know if there should be more flags that should be cleared.
For this use case lgtm.
mpkarpov-ui
approved these changes
Oct 23, 2026
mpkarpov-ui
left a comment
mpkarpov-ui
left a comment
Contributor
There was a problem hiding this comment.
looks good, should probably rebase to get ci to pass though
Contributor
I think these are the only relevant ones tbh, if you want to be thorough just clear the SAFE flag as well but that code would never be exercised anyway so this is good imo |
mpark108
force-pushed
the
bugfix/armed-transition-after-pt
branch
from
October 23, 2026 16:34
223bfec to
c8157d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the timeout from PYRO_TEST (10 seconds), the FSM is configured to automatically switch back to SAFE. In the past, if someone sends a command to go to the ARMED state while it is in the PYRO_TEST state, immediately after switching to SAFE, the FSM will evaluate and execute that command, going straight from PYRO_TEST to ARMED, which was not intended behavior. I've cleared the command flag for moving to ARMED when the timeout resets back to SAFE. I have tested the previous failure condition on the new software, and it has been fixed!